Skip to content

Conversation

@pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Nov 6, 2025

Changes

  • Bump github.com/tektoncd/chains from 0.25.1 to 0.26.0
  • Update the golden file to remove the creationTimestamp: null to fix the tests
  • Regenerated pkg/cmd/pipeline/testdata/signed.yaml and pkg/cmd/task/testdata/signed.yaml
    with fresh, valid signatures using the existing keys which was failing earlier
  • Replaced log.Fatalf() with return fmt.Errorf() for proper error handling

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 6, 2025
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 6, 2025
@pratap0007
Copy link
Contributor Author

/retest

@pratap0007
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2025
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2025
@pratap0007
Copy link
Contributor Author

/retest

@pratap0007
Copy link
Contributor Author

cc: @vdemeester

@pratap0007
Copy link
Contributor Author

/assign @divyansh42

dependabot bot and others added 2 commits November 19, 2025 11:27
Bumps [github.com/tektoncd/chains](https://github.com/tektoncd/chains) from 0.25.1 to 0.26.0.
- [Release notes](https://github.com/tektoncd/chains/releases)
- [Changelog](https://github.com/tektoncd/chains/blob/main/releases.md)
- [Commits](tektoncd/chains@v0.25.1...v0.26.0)

---
updated-dependencies:
- dependency-name: github.com/tektoncd/chains
  dependency-version: 0.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
- Update the golden file to remove the creationTimestamp: null
- Regenerated pkg/cmd/pipeline/testdata/signed.yaml and pkg/cmd/task/testdata/signed.yaml
  with fresh, valid signatures using the existing keys which was failing earlier
- Replaced log.Fatalf() with return fmt.Errorf() for proper error handling

Signed-off-by: Shiv Verma <[email protected]>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2025
@tekton-robot tekton-robot merged commit 676125c into tektoncd:main Nov 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants