-
Notifications
You must be signed in to change notification settings - Fork 262
Bump github.com/tektoncd/chains from 0.25.1 to 0.26.0 and fix tests #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/retest |
|
/retest |
|
/retest |
|
cc: @vdemeester |
|
/assign @divyansh42 |
Bumps [github.com/tektoncd/chains](https://github.com/tektoncd/chains) from 0.25.1 to 0.26.0. - [Release notes](https://github.com/tektoncd/chains/releases) - [Changelog](https://github.com/tektoncd/chains/blob/main/releases.md) - [Commits](tektoncd/chains@v0.25.1...v0.26.0) --- updated-dependencies: - dependency-name: github.com/tektoncd/chains dependency-version: 0.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
- Update the golden file to remove the creationTimestamp: null - Regenerated pkg/cmd/pipeline/testdata/signed.yaml and pkg/cmd/task/testdata/signed.yaml with fresh, valid signatures using the existing keys which was failing earlier - Replaced log.Fatalf() with return fmt.Errorf() for proper error handling Signed-off-by: Shiv Verma <[email protected]>
vdemeester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
with fresh, valid signatures using the existing keys which was failing earlier
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes