Cleanups #14632
Cleanups #14632
Conversation
| .wait() | ||
| .expect("failed to wait on \"beforeDevCommand\""); | ||
| if !(status.success() || KILL_BEFORE_DEV_FLAG.get().unwrap().load(Ordering::Relaxed)) { | ||
| if !(status.success() || KILL_BEFORE_DEV_FLAG.load(Ordering::Relaxed)) { |
There was a problem hiding this comment.
Although implausible, there's nothing stopping the child to exit before the flag gets initialized. Because the thread is spawned, this panic might be hard to detect.
Package Changes Through 4e748c4There are 3 changes which include tauri-utils with patch, tauri-build with patch, tauri-cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
I am a little concerned about d97b190 that it changed the timing on when we resolve the tauri directories which might get affected by the working directory (we do change them later on in some places) |
|
Removed the commit until can split it into changes more obviously correct. RFR |
|
Fixed CI |
Legend-Master
left a comment
Legend-Master
left a comment
There was a problem hiding this comment.
Looking good, thanks!
And you need to sign your commits 🙃
… in-sync, group them to one Option
…icitly through self
|
GTM |
Co-authored-by: Fabian-Lars <[email protected]>
3 participants
Got sidetracked, best read commit by commit.