feat: Add support for AppDocuments, AppLibrary and AppTemp (#12276) #14598
+829
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2276) Previously, there was no access to 3 specific paths used by iOS. We have added support for these directories, and added documentation explaining how these different methods are meant to be used. This also required the creation of a Swift plugin to allow us to access these iOS APIs. In this process, we have added a page to the sample views to immediately see the output of the different path methods. This required some visual fixes of the examples/api app for the menu button to be usable on modern Android devices to work with insets.)feat: Add support for AppLibrary, AppTemp, and AppCache (tauri-apps#12276) Previously, there was no access to 3 specific paths used by iOS. We have added support for these directories, and added documentation explaining how these different methods are meant to be used. This also required the creation of a Swift plugin to allow us to access these iOS APIs. In this process, we have added a page to the sample views to immediately see the output of the different path methods. This required some visual fixes of the examples/api app for the menu button to be usable on modern Android devices to work with insets.)
| /// | ||
| /// Not supported on desktop, returns error. | ||
| pub fn app_documents_dir(&self) -> Result<PathBuf> { | ||
| Err(Error::UnknownPath) |
Contributor
There was a problem hiding this comment.
Wouldn't we want these methods to resolve (or fall back) on desktop? Otherwise we'd need to handle desktop/mobile paths separately in the application.
Author
There was a problem hiding this comment.
I'm not sure what a sensible fallback would be for these on Desktop implementations would be, since these may not have direct translations to MacOS and Windows apps.
Do you have any thoughts on what a reasonable fallback would be for these methods on desktop?
onehumandev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add support for AppLibrary, AppTemp, and AppCache (#12276)
Previously, there was no access to 3 specific paths used by iOS.
We have added support for these directories, and added documentation
explaining how these different methods are meant to be used.
This also required the creation of a Swift plugin to allow us to access
these iOS APIs.
There was a thought that we would be able to add access to these directories
by setting a feature flag in the plugin and having conditional retrieval of
the needed directories.
However, this proved to be much more complex than needed, since in reality we are able to
make this a purely additive change, with the only changed output being for the
appCacheDirmethod on iOS. In the related issue #12276 , it was stated this could be acceptable.Comparisons of the returned values before and after these changes for both Android and iOS are
attached here.
Android comparison:
PostChangeResults-Android.csv
iOS comparison:
PostChangeResults-iOS.csv
In this process, we have added a page to the sample views to immediately
see the output of the different path methods.
This required some visual fixes of the examples/api app for the menu button
to be usable on modern Android devices to work with insets.)