-
Notifications
You must be signed in to change notification settings - Fork 1
feat: coming soon screen #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a reusable "Coming Soon" screen to serve as a placeholder for features currently under development, specifically for Contacts and Profile functionality. The changes remove the previous profile implementation from the home screen and redirect both profile and contacts navigation to the new placeholder screen.
Changes:
- Added a new
ComingSoonScreencomposable with navigation support - Removed profile suggestions from the home screen's suggestion lists
- Redirected profile and contacts navigation drawer items to the coming soon screen
- Removed profile icon and display from the home screen top bar
Reviewed changes
Copilot reviewed 6 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
app/src/main/res/values/strings.xml |
Added string resources for the coming soon screen UI elements |
app/src/main/java/to/bitkit/ui/screens/wallets/HomeViewModel.kt |
Removed Suggestion.PROFILE from all suggestion lists |
app/src/main/java/to/bitkit/ui/screens/wallets/HomeScreen.kt |
Simplified profile navigation to use new Routes.Profile and removed profile display from top bar |
app/src/main/java/to/bitkit/ui/screens/common/ComingSoonScreen.kt |
Created new ComingSoonScreen composable with image, text, and navigation button |
app/src/main/java/to/bitkit/ui/components/DrawerMenu.kt |
Implemented onClick handlers for contacts and profile drawer items |
app/src/main/java/to/bitkit/ui/ContentView.kt |
Added comingSoon navigation graph and defined Routes.Contacts and Routes.Profile |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
Sexy work, as always 🙌🏻 !
Approved with 2 nits 🎉
app/src/main/java/to/bitkit/ui/screens/common/ComingSoonScreen.kt
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck for review 2
Thx for addressing the comments 🙏🏻
# Conflicts: # app/src/main/res/values/strings.xml
|
We could be showing the Coming Soon page also when tapping the Contacts button in the send sheet. send.mp4PS. I reckon there's a few other places from where we could link to this new page, there was even a TODO comment somewhere. I accidentally stumbled upon it yesterday. |
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck again 👍🏻
One nit, in my comment before this review.
But I've decided to merge first, for the purpose of building the internal release app and sanity-checking the main flows before the testing session.
Then we can address the task of linking to the new page from extra places.
Sorry, forgot to check if these buttons were enabled. I'll fix them after #604 merge |
|
No worries, we'll tackle the rest with the issue: I'm quite certain there's a few other places! |
Closes #580
Description
Preview
Screen_recording_20260113_143629.webm
QA Notes