Adding forward-compatibility for sphinx 9. #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you please fix the CI? |
SilverRainZ
reviewed
Jan 2, 2026
src/ablog/blog.py
Outdated
| return self.docwriter.parts["fragment"] | ||
|
|
||
| try: | ||
| # sphinx >= 9 |
Contributor
There was a problem hiding this comment.
You can test sphinx.version_info[0] >= 9 here.
Signed-off-by: Daniel Baumann <[email protected]>
Contributor
|
Hi @nabobalis, can you please merge this when you are free? B.T.W. I heavily use this extension; Perhaps I could become a member of the maintainers and help handle issues and pull requests. |
Member
|
Hello @SilverRainZ, I have stepped back from maintain projects under the sunpy umbrella as a result, I lack any write access to this repository anymore. Hopefully someone from the @sunpy/sunpy-core-team will be able to review and merge this PR. Thank you @daniel-baumann for opening the PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
with sphinx 9.x, ablog doesn't work (see #313).
This commit fixes it by first trying the new code for sphinx 9.x, but keeping the legacy compatiblity for sphinx 8 in place as fallback.
Please consider merging it.
Regards,
Daniel