Skip to content

Conversation

@ramzie007
Copy link
Contributor

I accidentally first placed the plugins into /turtleblocksjs, hence then I deleted it from there and placed it in /turtleblocksjs/plugins. That is why it is showing 4 changes done.

@tradzik
Copy link
Contributor

tradzik commented Dec 25, 2016

Hey!

From code quality - instead of using long and repeatable if statements, I would recommend taking a look on the switch statement (Reference).

Additionally it will be nice if you squash your commits into one before decision about merging your changes. Having multiple commits regarding the same issue causes mess in the repository.

Best,
Tymon

@tradzik
Copy link
Contributor

tradzik commented Dec 31, 2016

We have updated plugin's JSON file structure. Could you also regenerate your JSON file with pluginify.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants