[WIP] Multizone adjoints for turbomachinery #2446

joshkellyjak · 2025-02-18T16:22:06Z

Proposed Changes

This is a cleaned up PR of the fixes needed for multizone adjoints for turbomachinery from the previous PR of @oleburghardt and I's work.

This hopefully is useable, so if you would like to test and report please feel free to contact me on Slack.

TODO:

Fix eddy viscosity tape issue in CNSSolver
Add turbomachinery objective functions + constraints
Include MZ testcase

Related Work

Now closed PR #2317

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

[ X ] I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

pcarruscag · 2025-02-20T08:51:45Z

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

+    AD::EndPreacc();
+
    /*--- Max is not differentiable, so we not register them for preacc. ---*/


What is the difference between ending the preaccumulation before or after?

pcarruscag · 2025-02-20T08:51:59Z

Common/src/CConfig.cpp

+      }
    }
+  } else if (Multizone_Problem && DiscreteAdjoint) {
+      SU2_MPI::Error(string("OUTPUT_WRT_FREQ cannot be specified for this solver "


Suggested change

SU2_MPI::Error(string("OUTPUT_WRT_FREQ cannot be specified for this solver "

SU2_MPI::Error("OUTPUT_WRT_FREQ cannot be specified for this solver "

pcarruscag · 2025-02-20T08:52:47Z

Common/src/CConfig.cpp

+                            "(writing of restart and sensitivity files not possible for multizone discrete adjoint during runtime yet).\n"
+                            "Please remove this option from the config file, output files will be written when solver finalizes.\n"), CURRENT_FUNCTION);


Hmmm I'm pretty sure it is possible

This is one for @oleburghardt

Yes and no, writing the files is fine, but the continuation of the multi-zone discrete adjoint solver is erratic. My guess is that some indices aren't cleared properly before re-recording the tape. (Writing adjoint solution variables to file only, without re-recording at all and without sensitivities, might give us some hints.)
The debug mode could eventually pin down where exactly things go wrong.

pcarruscag · 2025-02-20T08:55:35Z

SU2_CFD/src/solvers/CDiscAdjSolver.cpp

-    BPressure = config->GetPressureOut_BC();
-    Temperature = config->GetTotalTemperatureIn_BC();
-
    if (!reset){
      AD::RegisterInput(BPressure);
      AD::RegisterInput(Temperature);
    }

+    BPressure = config->GetPressureOut_BC();
+    Temperature = config->GetTotalTemperatureIn_BC();
+


Why are these wrong but not the others that follow the same pattern?

This threw a tagging error, and if I remember correctly it's because in the other sections the variables it accesses are directly used in the solver, whereas in the Giles implementation they are not, creating a mismatch in tags.

Can we fix it in a way that keeps a clear pattern for doing this type of thing?

I can give it a go

…ding of objective function calculation

…e_mz_turbomachinery_adjoint

SU2_CFD/src/iteration/CDiscAdjFluidIteration.cpp

SU2_CFD/src/iteration/CTurboIteration.cpp

SU2_CFD/src/solvers/CEulerSolver.cpp

… to run in quasi-MZ approach. (NEEDS CLEANING)

SU2_CFD/src/drivers/CDiscAdjMultizoneDriver.cpp

SU2_CFD/src/integration/CIntegration.cpp

SU2_CFD/src/iteration/CDiscAdjFluidIteration.cpp

… MZ turbo testcase

SU2_CFD/src/drivers/CDriver.cpp

…ables in turbo averaging

SU2_CFD/src/interfaces/cfd/CMixingPlaneInterface.cpp

SU2_CFD/src/iteration/CFluidIteration.cpp

SU2_CFD/src/interfaces/cfd/CMixingPlaneInterface.cpp

SU2_CFD/src/drivers/CDriver.cpp

SU2_CFD/include/iteration/CFluidIteration.hpp

joshkellyjak · 2025-11-30T21:38:07Z

With last commit discrete adjoints with RANS for turbomachinery appears to be working, at least in 2D. We absolutely need to perform a full validation of some of the turbomachinery testcases we have acquired with the turbo working group as there are some pretty significant changes in the primal solver (mixing plane) so this may take some more time before I am confident that everything is correct.

…m/su2code/SU2 into feature_mz_turbomachinery_adjoint

SU2_CFD/src/interfaces/cfd/CMixingPlaneInterface.cpp

…r MP.

Common/src/interface_interpolation/CMixingPlane.cpp

+            switch(donor_config->GetKind_MixingPlaneInterface()){
+                case MATCHING:
+                    targetSpan.donorSpan = iSpanTarget;
+                    targetSpan.coefficient = 0.0;
+                    break;
+
+                case NEAREST_SPAN:
+                    // Find the nearest donor span
+                    for (auto iSpanDonor = 0; iSpanDonor < nSpanDonor - 1; iSpanDonor++) {
+                        const auto dist = abs(spanValuesTarget[iSpanTarget] - spanValuesDonor[iSpanDonor]);
+                        if(dist < minDist){
+                            minDist = dist;
+                            tSpan = iSpanDonor;
+                        }
+                    }
+                    targetSpan.donorSpan = tSpan;
+                    targetSpan.coefficient = 0.0;
+                    break;
+
+                case LINEAR_INTERPOLATION:
+                {
+                    bool printWarning = false;
+                    // Check if target span is within donor bound
+                    if (spanValuesTarget[iSpanTarget] <= spanValuesDonor[0]) {
+                        // Below hub - use hub value
+                        targetSpan.donorSpan = 0;
+                        targetSpan.coefficient = 0.0;
+                        printWarning = true;
+                    }
+                    else if (spanValuesTarget[iSpanTarget] >= spanValuesDonor[nSpanDonor - 1]) {
+                        // Above shroud - use shroud value
+                        targetSpan.donorSpan = nSpanDonor - 1;
+                        targetSpan.coefficient = 0.0;
+                        printWarning = true;
+                    }
+                    else {
+                        // Find the donor span interval that brackets the target span
+                        for (auto iSpanDonor = 0; iSpanDonor < nSpanDonor - 1; iSpanDonor++) {
+                            const auto test = abs(spanValuesTarget[iSpanTarget] - spanValuesDonor[iSpanDonor]);
+                            if(test < minDist && spanValuesTarget[iSpanTarget] > spanValuesDonor[iSpanDonor]){
+                                kSpan = iSpanDonor;
+                                minDist = test;
+                            }
+                        }
+                        // Calculate interpolation coefficient
+                        coeff = (spanValuesTarget[iSpanTarget] - spanValuesDonor[kSpan]) / 
+                                (spanValuesDonor[kSpan + 1] - spanValuesDonor[kSpan]);
+                        targetSpan.donorSpan = kSpan;
+                        targetSpan.coefficient = coeff;
+                    }
+                    if (printWarning) {
+                        if (rank == MASTER_NODE) {
+                            cout << "Warning! Target spans exist outside the bounds of donor spans! Clamping interpolator..." <<  endl;
+                            if (spanValuesTarget[iSpanTarget] <= spanValuesDonor[0]) cout << "This is an issue at the hub." << endl;
+                            if (spanValuesTarget[iSpanTarget] >= spanValuesDonor[nSpanDonor - 1]) cout << "This is an issue at the shroud." << endl;
+                            cout << "Setting coeff = 0.0 and transferring endwall value!" << endl;
+                        }
+                    }
+                    break;
+                }
+                default:
+                    SU2_MPI::Error("MixingPlane interface option not implemented yet", CURRENT_FUNCTION);
+                    break;
+            }


To fix this issue, we should extract the lengthy content of the LINEAR_INTERPOLATION case into a dedicated method of CMixingPlane, such as HandleLinearInterpolation(...). This method should receive all the inputs needed (iSpanTarget, the spanValuesTarget/spanValuesDonor arrays, nSpanDonor, and so forth), and update the corresponding targetSpan for the current iteration. This reduces the switch case to a single function call for the LINEAR_INTERPOLATION case, improving readability and maintainability. Only code in the immediate code region related to the LINEAR_INTERPOLATION case and the class implementation may be changed; we must not touch files or lines not shown, nor alter unrelated imports or logic. The new function definition should be placed within the same file, as an appropriate member of CMixingPlane.

Fixes from tagging tool

98989f7

joshkellyjak added PR: draft changelog:feature labels Feb 18, 2025

Config catch + fix preacc in ComputeVorticityandStrainMag

6082eac

oleburghardt mentioned this pull request Feb 19, 2025

[WIP] Multizone discrete adjoints for turbomachinery #2317

Closed

pcarruscag reviewed Feb 20, 2025

View reviewed changes

Initial add turbo obj functions

b3267b6

joshkellyjak mentioned this pull request Feb 25, 2025

Update CTurbSSTSolver.cpp to fix bug on calculating MuT #2453

Merged

6 tasks

Initial refactoring of turboperformance into solver for correct recor…

c459ce9

…ding of objective function calculation

oleburghardt mentioned this pull request Mar 21, 2025

Fix preaccumulation error, improve recording of RANS solvers #2472

Merged

6 tasks

Joshua Kelly added 2 commits March 21, 2025 13:06

Merge remote-tracking branch 'origin/fix_small_AD_issues' into featur…

4a58b8c

…e_mz_turbomachinery_adjoint

Adding geometry to AD recording for turbo calcs. (NOT WORKING CURRENTLY)

1614784

github-advanced-security bot found potential problems May 1, 2025

View reviewed changes

SU2_CFD/src/iteration/CDiscAdjFluidIteration.cpp Fixed Show fixed Hide fixed

SU2_CFD/src/iteration/CTurboIteration.cpp Fixed Show fixed Hide fixed

SU2_CFD/src/solvers/CEulerSolver.cpp Fixed Show fixed Hide fixed

Singlezone working with validated gradients and turbo obj funcs. Need…

d43fef5

… to run in quasi-MZ approach. (NEEDS CLEANING)

github-advanced-security bot found potential problems Jun 9, 2025

View reviewed changes

SU2_CFD/src/drivers/CDiscAdjMultizoneDriver.cpp Fixed Show fixed Hide fixed

SU2_CFD/src/integration/CIntegration.cpp Fixed Show fixed Hide fixed

SU2_CFD/src/iteration/CDiscAdjFluidIteration.cpp Fixed Show fixed Hide fixed

joshkellyjak and others added 8 commits August 25, 2025 11:03

Merge branch 'develop' into feature_mz_turbomachinery_adjoint

6c9de92

Merge branch 'develop' into feature_mz_turbomachinery_adjoint

0e03ead

Messy commit of refactoring

ae2f001

Cleaned up branch + Euler MZ working / Issues with RANS remain + Init…

32956c4

… MZ turbo testcase

Merge branch 'develop' into feature_mz_turbomachinery_adjoint

435bea6

merge issue

912aeea

Unused var

a0bfb53

Unused var

1303145

github-advanced-security bot found potential problems Oct 12, 2025

View reviewed changes

SU2_CFD/src/drivers/CDriver.cpp Fixed Show fixed Hide fixed

joshkellyjak added 6 commits November 10, 2025 09:57

Fixes to fluid interface for disc adj + proper recording of turb vari…

23bf8c3

…ables in turbo averaging

Initial reformat of mixing plane implementation

af78550

Fixes

2c8bf76

Fixing mixing state data structure

a5d0d73

Correct targetVars

542e3cb

Fixes + working MPI MP interface

9a201ac

joshkellyjak and others added 3 commits November 29, 2025 01:26

Overload compile issues

744d823

compiler warnings

a065954

compiler warnings

3616b15

github-advanced-security bot found potential problems Nov 29, 2025

View reviewed changes

joshkellyjak and others added 3 commits November 29, 2025 19:06

compiler warnings + unused code

ea53796

Grid Velocity fixes for fluid-fluid interfaces

c3d8fb5

Merge branch 'develop' into feature_mz_turbomachinery_adjoint

2daecb7

joshkellyjak added 4 commits November 30, 2025 21:50

CodeQL Comments

0e331f8

Merge branch 'feature_mz_turbomachinery_adjoint' of https://github.co…

79533db

…m/su2code/SU2 into feature_mz_turbomachinery_adjoint

Compiler warning

75a7160

formatting

cdc4bd6

github-advanced-security bot found potential problems Nov 30, 2025

View reviewed changes

SU2_CFD/src/interfaces/cfd/CMixingPlaneInterface.cpp Fixed Show fixed Hide fixed

joshkellyjak added 16 commits December 1, 2025 05:58

Compiler warnings

4b25e22

Resolve casting complaints

8f361bf

Unused var

fac7b3c

Added fluid interface testcases

f3daa3d

Unused var

030b1b3

Added writing of mixing plane interpolator to file + interpolation fixes

69e812d

MP bug fix and additional interpolation warning details

ed89e9d

MPI correction

e440f9c

Proper identification of MP boundaries w/ MPI + filename fix

ce08ca6

Interpolator correction

771c098

MPI fixes

3150c51

MPI issues

96e830f

Remove SetAverageValues

51a1a86

Fix type definition of marker buffer

0d1ac6d

Assorted MPI Fixes and updates of interpolation classes to account fo…

fd20657

…r MP.

Fix identification of marker boundaries at mixing plane interface

7b78f06

github-advanced-security bot found potential problems Dec 9, 2025

View reviewed changes

		AD::EndPreacc();

		/--- Max is not differentiable, so we not register them for preacc. ---/

	SU2_MPI::Error(string("OUTPUT_WRT_FREQ cannot be specified for this solver "
	SU2_MPI::Error("OUTPUT_WRT_FREQ cannot be specified for this solver "

		"(writing of restart and sensitivity files not possible for multizone discrete adjoint during runtime yet).\n"
		"Please remove this option from the config file, output files will be written when solver finalizes.\n"), CURRENT_FUNCTION);

[WIP] Multizone adjoints for turbomachinery #2446

Are you sure you want to change the base?

[WIP] Multizone adjoints for turbomachinery #2446

Uh oh!

Conversation

joshkellyjak commented Feb 18, 2025

Proposed Changes

Related Work

PR Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oleburghardt Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshkellyjak commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Check notice

Uh oh!

Copilot Autofix

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oleburghardt Mar 25, 2025 •

edited

Loading

joshkellyjak commented Nov 30, 2025 •

edited

Loading