-
Notifications
You must be signed in to change notification settings - Fork 257
[feat] Add JSONSchemas #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces JSON schema definitions for a Component Gallery catalog system. The schemas provide structured validation for component submissions and the compiled component catalog.
Changes:
- Added
component.schema.jsonfor validating individual component submission data - Added
compiled.schema.jsonfor validating the compiled components catalog structure - Defined comprehensive validation rules including required fields, format constraints, and category enumerations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| directory/schemas/component.schema.json | Defines schema for component submission with validation for metadata, author info, links, categories, and governance |
| directory/schemas/compiled.schema.json | Defines schema for compiled catalog including metrics, ranking signals, and aggregated component data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a9e06e1 to
91e2fa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
directory/schemas/component.schema.json:1
- Inconsistent capitalization: 'Github' should be 'GitHub' to match the standard brand name and other references in the schema (e.g., 'gitHubUrl' at line 30, 62).
{
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
91e2fa0 to
a2a0b92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a2a0b92 to
518eaab
Compare
| "enum": [ | ||
| "LLMs", | ||
| "Widgets", | ||
| "Charts", | ||
| "Authentication", | ||
| "Connections", | ||
| "Images & video", | ||
| "Audio", | ||
| "Text", | ||
| "Maps", | ||
| "Dataframes", | ||
| "Graphs", | ||
| "Molecules & genes", | ||
| "Code editors", | ||
| "Page navigation", | ||
| "Developer tools", | ||
| "Integrations" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is it safe to assume this isn't difficult to adjust in the future and that this is based on the already existing categories?
sfc-gh-nbellante
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 1 non-blocking question

TL;DR
Added JSON schema definitions for the Component Gallery catalog system.
What changed?
compiled.schema.jsonwhich defines the structure for the compiled components catalogcomponent.schema.jsonwhich defines the structure for individual component submissionsWhy make this change?
These schema definitions provide a standardized structure for component submissions and the compiled catalog, ensuring: