-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add number/float16/base/signbit
#9390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add number/float16/base/signbit
#9390
Conversation
|
/stdlib update-copyright-years |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Given that Repl error is not caused to know changes related to this PR hence I'll go ahead and open this for Review! |
lib/node_modules/@stdlib/number/float16/base/signbit/benchmark/c/benchmark.c
Show resolved
Hide resolved
Signed-off-by: Neeraj Pathak <[email protected]>
lib/node_modules/@stdlib/number/float16/base/signbit/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Neeraj Pathak <[email protected]>
|
staying consistent with the |
lib/node_modules/@stdlib/number/float16/base/signbit/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/number/float16/base/signbit/manifest.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Gururaj Gurram <[email protected]> Signed-off-by: Neeraj Pathak <[email protected]>
Co-authored-by: Gururaj Gurram <[email protected]> Signed-off-by: Neeraj Pathak <[email protected]>
|
@gururaj1512 Thank you for catching this!! |
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/number/float16/base/signbit/examples/index.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/number/float16/base/signbit/docs/repl.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/number/float16/base/signbit/src/addon.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/number/float16/base/signbit/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/number/float16/base/signbit/test/test.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after clean-up.
|
As the CI failure is expected, I'll go ahead and merge. |
Resolves none.
Description
This pull request:
number/float16/base/signbitRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers