Skip to content

Conversation

@tatu-at-datastax
Copy link
Contributor

What this PR does:

Converts yet more ErrorCodeV1 entries to new Error entities

Which issue(s) this PR fixes:
Part of #2285

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax self-assigned this Jan 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

📉 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 50.59%
This PR 50.59%
Delta 🔴 -0.00%
⚠️ Coverage decreased

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Unit Test Coverage Report

Overall Project 50.59% -0.11% 🍏
Files changed 66.36% 🍏

File Coverage
DocumentException.java 100% 🍏
JsonApiException.java 96.18% 🍏
ErrorCodeV1.java 94.55% 🍏
JsonUtil.java 86.81% -0.39% 🍏
DocumentId.java 80.45% -3.18% 🍏
EmbeddingProvidersConfig.java 72.73% -4.96%
WritableShreddedDocument.java 70.81% -1.12%
DocumentShredder.java 65.48% -7.01%

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

📉 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 72.46%
This PR 72.43%
Delta 🔴 -0.03%
⚠️ Coverage decreased

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Integration Test Coverage Report (hcd-it)

Overall Project 72.43% -0.14% 🍏
Files changed 56.17%

File Coverage
DocumentException.java 100% 🍏
ErrorCodeV1.java 94.55% 🍏
JsonApiException.java 91.59% 🍏
JsonUtil.java 87.2% -0.39% 🍏
DocumentShredder.java 86.19% -3.19% 🍏
EmbeddingProvidersConfig.java 78.51% -4.96%
WritableShreddedDocument.java 67.6% 🍏
DocumentId.java 62.5% -22.27%

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

📉 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 70.67%
This PR 70.64%
Delta 🔴 -0.03%
⚠️ Coverage decreased

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Integration Test Coverage Report (dse69-it)

Overall Project 70.64% -0.14% 🍏
Files changed 56.17%

File Coverage
DocumentException.java 100% 🍏
ErrorCodeV1.java 94.55% 🍏
JsonApiException.java 91.59% 🍏
JsonUtil.java 87.2% -0.39% 🍏
DocumentShredder.java 83.81% -3.19% 🍏
EmbeddingProvidersConfig.java 78.51% -4.96%
WritableShreddedDocument.java 66.62% 🍏
DocumentId.java 62.5% -22.27%

return OPTIONS;
}
throw ErrorCodeV1.INVALID_PARAMETER_VALIDATION_TYPE.toApiException(type);
throw new IllegalArgumentException(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-off failure not to be directly exposed: caller will wrap/convert validation problems in more centralized way.

@tatu-at-datastax tatu-at-datastax marked this pull request as ready for review January 3, 2026 01:32
@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner January 3, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants