Skip to content

(WIP) Fix #1186: no fail for invalid keyspace for HCD #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tatu-at-datastax wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

(WIP) Fix #1186: no fail for invalid keyspace for HCD #2026

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d36be95
Fix #1186: no fail for invalid keyspace for HCD
tatu-at-datastax Apr 24, 2025
cf61200
Merge branch 'main' into tatu/1186-drop-collection-bad-ks
tatu-at-datastax May 5, 2025
5c818cf
Merge branch 'main' into tatu/1186-drop-collection-bad-ks
tatu-at-datastax May 12, 2025
193ac1d
Merge branch 'main' into tatu/1186-drop-collection-bad-ks
tatu-at-datastax Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/test/java/io/stargate/sgv2/jsonapi/api/v1/DeleteCollectionIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import static io.stargate.sgv2.jsonapi.api.v1.ResponseAssertions.responseIsDDLSuccess;
import static io.stargate.sgv2.jsonapi.api.v1.ResponseAssertions.responseIsError;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.is;

import io.quarkus.test.common.WithTestResource;
Expand Down Expand Up @@ -84,6 +86,27 @@ public void notExisting() {
.body("status.ok", is(1));
}

// [data-api#1186]: handling of non-existing keyspace
@Test
public void nonExistingKeyspace() {
givenHeadersAndJson(
"""
{
"deleteCollection": {
"name": "some-collection"
}
}
""")
.when()
.post(KeyspaceResource.BASE_PATH, "no_such_keyspace")
.then()
.statusCode(200)
.body("$", responseIsError())
.body("errors", hasSize(1))
.body("errors[0].errorCode", is("KEYSPACE_DOES_NOT_EXIST"))
.body("errors[0].message", containsString("no_such_keyspace"));
}

@Test
public void invalidCommand() {
givenHeadersAndJson(
Expand All @@ -98,8 +121,8 @@ public void invalidCommand() {
.then()
.statusCode(200)
.body("$", responseIsError())
.body("errors", hasSize(1))
Copy link
Contributor Author

@tatu-at-datastax tatu-at-datastax May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change, clean up.

.body("errors[0].errorCode", is("COMMAND_FIELD_INVALID"))
.body("errors[0].exceptionClass", is("JsonApiException"))
.body(
"errors[0].message",
is(
Expand Down
Loading