chore: helm chart configuration #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJBurns
reviewed
Nov 13, 2025
- Remove ct lint step (too restrictive, requires maintainers) - Remove chart-testing-action setup (unused) - Add --kube-version 1.28.0 to helm template for compatibility - Fix Chart.yaml URLs to point to stacklok/toolhive-cloud-ui - Remove maintainers field (not required without ct lint) - Align with toolhive operator chart structure
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive Helm chart configuration for deploying the ToolHive Cloud UI Next.js application to Kubernetes, with optimization for local development using Kind.
Key Changes:
- Complete Helm chart with deployment, service, HPA, and service account templates
- Development and production value configurations with security contexts and resource limits
- Makefile targets for Kind cluster management and deployment automation
- CI/CD workflows for Helm chart linting and integration testing
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| helm/Chart.yaml | Helm chart metadata defining v0.1.0 with Next.js/React keywords and Kubernetes 1.24+ requirement |
| helm/values.yaml | Default configuration with security contexts, probes, and resource limits |
| helm/values-dev.yaml | Development overrides with faster probes and local image pull settings |
| helm/templates/_helpers.tpl | Template helpers for consistent naming and labeling across resources |
| helm/templates/deployment.yaml | Kubernetes Deployment with configurable replicas, security contexts, and health checks |
| helm/templates/service.yaml | ClusterIP service exposing port 80 with NodePort support |
| helm/templates/serviceaccount.yaml | Conditional ServiceAccount creation with configurable token automount |
| helm/templates/hpa.yaml | Optional HorizontalPodAutoscaler with CPU/memory-based scaling |
| helm/.helmignore | Standard Helm ignore patterns for VCS, backups, and IDE files |
| Makefile | Added Kind cluster management targets (create, delete, deploy, logs, port-forward) |
| README.md | Documentation for Kubernetes deployment with Kind quick start guide |
| .github/workflows/lint-helm.yml | CI workflow for Helm chart syntax validation and template rendering |
| .github/workflows/helm-test.yml | Integration test workflow deploying to Kind and verifying app response |
| .gitignore | Added Helm-specific ignore patterns for charts and lock files |
| Dockerfile | Simplified comment on dependency installation line |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add RELEASE_NAME variable to avoid hardcoded deployment name - Use variable in kind-deploy, kind-uninstall, kind-logs, kind-port-forward - Improves flexibility and maintainability - Addresses Copilot review suggestion
peppescg
changed the title
ChrisJBurns
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure helm chart and use kind for testing it in ci
Tested locally as well with kind