fix: Enhance Permission Validation #273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add TestValidatePermissions to verify permission validation works correctly - Test valid permissions: read, write, list, execute, super - Test invalid permissions: delete, admin, create, typos like 'raed' - Ensures CLI properly rejects invalid permissions at validation time - All tests pass, addressing issue spiffe#253 Signed-off-by: majiayu000 <[email protected]>
Contributor
|
Thanks for your contribution 🙏 . I will check this out next year :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #253 by adding comprehensive test coverage for the validatePermissions function.
Changes
Testing
All existing tests pass, and the new tests verify that the SDK's ValidatePermissions function properly rejects invalid permissions at validation time, preventing them from being stored in the database.
Generated with Claude Code