IN_LIBXML no longer needed for windows linkage #3475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Well, apparently we don't need it anymore! 🙌 |
and the analogous workarounds for libxslt and libexslt
flavorjones
force-pushed
the
flavorjones-remove-in-libxml-define
branch
from
624a040 to
5046750
Compare
flavorjones
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
In a comment in #3470, @nwellnhof mentioned his surprise that we were linking with
IN_LIBXMLon windows.This change was introduced in 7ace791 as part of the fix for #2167, in which I struggled to get symbols to resolve on Windows.
Note that we also use
IN_LIBXSLTandIN_LIBEXSLTas of ba290a4.Lots has changed in the intervening four years, let's see what happens if I remove it now.