Skip to content

Conversation

@yume-chan
Copy link
Contributor

@yume-chan yume-chan commented Oct 23, 2024

removeTag missing a break causing all previous <title> tags to be rendered.

Repro playground: https://playground.solidjs.com/anonymous/4fa1f8e7-fcb6-4f6c-a521-daf6207fc779 (looks like @solidjs/meta doesn't work well with HMR, so I need to refresh the preview every time I edited the source code)

For whatever reason, I need to add babel-jest package to root package.json for tests to run. I installed with [email protected] but it still dramatically changed the lockfile, however, it didn't add any new packages.

Output from pnpm test after cloning and pnpm i:

~/solidjs/solid-meta main 3s
❯ pnpm test

> @solidjs/[email protected] test /home/solidjs/solid-meta
> jest && npm run test:types

: ● Validation Error:

  Module babel-jest in the transform option was not found.
         <rootDir> is: /home/solidjs/solid-meta

  Configuration Documentation:
  https://jestjs.io/docs/configuration.html

 ELIFECYCLE  Test failed. See above for more details.

@birkskyum
Copy link
Member

@yume-chan , can you add at test for this?

@yume-chan
Copy link
Contributor Author

@birkskyum
Copy link
Member

Ah, excellent - if you rebase, it should run it on vitest here in the CI.

@birkskyum birkskyum merged commit ae8e8ff into solidjs:main Apr 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants