Fix --xl and --extract options being ignored when using templates #1327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1296
The
--xl(--extract-last) and-x(--extract) command-line options were being completely overwritten when loading a template, instead of being combined with the template's settings. This meant that running:Would ignore the
--xlflag if the template didn't haveextract_last: trueset.The Bug
In
cli.py, when a template is loaded, the code was:This overwrites any CLI flags the user passed.
The Fix
Changed to use
orto combine CLI flags with template settings:Now the user can use
--xlor-xwith any template, regardless of whether the template has those options configured.Testing
Reproduction
Before this fix:
After this fix:
llm --template pelican --xl # Correctly extracts last fenced code block