V0.6 #11
Merged
V0.6 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tested on Debian 9, you may have to adjust paths/uids if your deployment differs
- should fix systemd integration
- typo if there were over 50k messages in inventory caused PyBM to stall
- was broken if there was no error message in "raise" - added default texts for network exceptions
- also minor style fixes
- don't make empty download requests - use smaller chunks when they can be spread across multiple connections
- change forking exit order as systemd expects (wait until child is ready, then exit parent, then grandparent) - fix signal handler if prctl not installed - revert recent PID file changes
- forgot to revert a line in previous commit
- surprisingly, it only was broken on some systems, e.g. Debian 8
- will try to report "Server full" over protocol for 10 extra connections over limit, instead of simply dropping them - if connected to the same host inbound and outbound, handle as server full (prevents duplicate connections)
- should be slightly more accurate and use slightly fewer resources
- shouldn't throw an exception if argument is a string rather than Peer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018 #1