Add seer tag when flask #937
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #937 +/- ##
==========================================
- Coverage 26.70% 26.65% -0.05%
==========================================
Files 41 41
Lines 1101 1103 +2
Branches 121 122 +1
==========================================
Hits 294 294
- Misses 787 789 +2
Partials 20 20
|
maxkosty
requested changes
Dec 7, 2025
Collaborator
maxkosty
left a comment
maxkosty
left a comment
There was a problem hiding this comment.
Looks like we never shipped this. Some comments
| return; | ||
| } | ||
|
|
||
| if(getTag('backendType') === 'flask') { |
Collaborator
There was a problem hiding this comment.
Now 2 more backends have a well-tested seer RCA+solution
Suggested change
| if(getTag('backendType') === 'flask') { | |
| if(['flask', 'laravel', 'flask-otlp'].includes(getTag('backendType'))) { |
Comment on lines
+51
to
+116
| // test('sets seerDemo tag when backendType is flask', async () => { | ||
| // const mockGetCurrentScope = jest.fn(() => ({ | ||
| // _tags: { backendType: 'flask' } | ||
| // })); | ||
| // Sentry.getCurrentScope.mockImplementation(mockGetCurrentScope); | ||
|
|
||
| // render( | ||
| // <Provider store={store}> | ||
| // <Router> | ||
| // <Checkout backend="/api" rageclick={false} /> | ||
| // </Router> | ||
| // </Provider> | ||
| // ); | ||
|
|
||
| // // Trigger checkout by submitting the form | ||
| // fireEvent.submit(screen.getByRole('button', { name: /Complete order/i })); | ||
|
|
||
| // await waitFor(() => { | ||
| // expect(Sentry.setTag).toHaveBeenCalledWith('seerDemo', true); | ||
| // }); | ||
| // }); | ||
|
|
||
| // test('does not set seerDemo tag when backendType is not flask', async () => { | ||
| // const mockGetCurrentScope = jest.fn(() => ({ | ||
| // _tags: { backendType: 'express' } | ||
| // })); | ||
| // Sentry.getCurrentScope.mockImplementation(mockGetCurrentScope); | ||
|
|
||
| // render( | ||
| // <Provider store={store}> | ||
| // <Router> | ||
| // <Checkout backend="/api" rageclick={false} /> | ||
| // </Router> | ||
| // </Provider> | ||
| // ); | ||
|
|
||
| // // Trigger checkout by submitting the form | ||
| // fireEvent.submit(screen.getByRole('button', { name: /Complete order/i })); | ||
|
|
||
| // await waitFor(() => { | ||
| // expect(Sentry.setTag).not.toHaveBeenCalledWith('seerDemo', true); | ||
| // }); | ||
| // }); | ||
|
|
||
| // test('does not set seerDemo tag when backendType is undefined', async () => { | ||
| // const mockGetCurrentScope = jest.fn(() => ({ | ||
| // _tags: {} | ||
| // })); | ||
| // Sentry.getCurrentScope.mockImplementation(mockGetCurrentScope); | ||
|
|
||
| // render( | ||
| // <Provider store={store}> | ||
| // <Router> | ||
| // <Checkout backend="/api" rageclick={false} /> | ||
| // </Router> | ||
| // </Provider> | ||
| // ); | ||
|
|
||
| // // Trigger checkout by submitting the form | ||
| // fireEvent.submit(screen.getByRole('button', { name: /Complete order/i })); | ||
|
|
||
| // await waitFor(() => { | ||
| // expect(Sentry.setTag).not.toHaveBeenCalledWith('seerDemo', true); | ||
| // }); | ||
| // }); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the backend service called during the checkout flow is flask, set the seerDemo tag to true. This will enable team members to find example issues for the seer demo easily.
Testing: