feat(scrat): Interface for symbol analysis RPC calls #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds ATD types for RPC calls to run or run + upload symbol analysis for a project.
|
Backwards compatibility summary: |
salolivares
approved these changes
Nov 21, 2025
semgrep_output_v1.atd
Outdated
|
|
||
| (* the language of the files to analyze; this will ideally be | ||
| optional/ignored in the future *) | ||
| lang : string; |
Member
There was a problem hiding this comment.
Should we make this optional today? We can keep passing it in, but we will have to potentially modify any ocaml code that relies on it existing.
Contributor
Author
There was a problem hiding this comment.
Hmm, yeah, we can do that. It feels a bit awkward, but it will make it easier to add per-file language detection in a backwards-compatible way in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ATD types for RPC calls to run or run + upload symbol analysis for a project.
Toward SC-2975
make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!
semgrep-proprietaryare approved and ready to merge once this PR is merged