Skip to content

Conversation

@ori-kron-wis
Copy link
Collaborator

No description provided.

WinterHannah and others added 30 commits May 13, 2025 16:41
Update feature branch to match upstream/main
…test-linux

Chore/ci disable schedule test linux
…-in-glue

2 basic batch encoding like in glue
…nce-graph-merge

merge to fix divergent branches
Update test_linux_custom_dataloader.yml
# for custom dataloders
dataloaders = ["lamindb>=1.12.1", "cellxgene-census", "tiledbsoma", "tiledbsoma_ml", "torchdata"]
# for diagvi
diagvi = ["torch_geometric", "geomloss"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need geomloss? It doesn't seem to be actively maintained.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Can, at the moment we rely on geomloss to compute the unbalanced optimal transport loss component. However, we are working on another approach based on POT, which is more actively maintained.

@ori-kron-wis ori-kron-wis mentioned this pull request Oct 30, 2025
@ori-kron-wis ori-kron-wis marked this pull request as ready for review October 30, 2025 12:10
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 72.15347% with 225 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.65%. Comparing base (5326dfa) to head (e2f5dee).

Files with missing lines Patch % Lines
src/scvi/external/diagvi/_model.py 73.16% 84 Missing ⚠️
src/scvi/external/diagvi/_base_components.py 43.65% 71 Missing ⚠️
src/scvi/external/diagvi/_module.py 70.22% 39 Missing ⚠️
src/scvi/external/diagvi/_utils.py 79.36% 26 Missing ⚠️
src/scvi/external/diagvi/_task.py 95.23% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3575      +/-   ##
==========================================
- Coverage   75.22%   74.65%   -0.58%     
==========================================
  Files         225      231       +6     
  Lines       21637    22444     +807     
==========================================
+ Hits        16277    16756     +479     
- Misses       5360     5688     +328     
Files with missing lines Coverage Δ
src/scvi/external/__init__.py 85.71% <100.00%> (+0.42%) ⬆️
src/scvi/external/diagvi/__init__.py 100.00% <100.00%> (ø)
src/scvi/model/base/_base_model.py 76.24% <100.00%> (ø)
src/scvi/external/diagvi/_task.py 95.23% <95.23%> (ø)
src/scvi/external/diagvi/_utils.py 79.36% <79.36%> (ø)
src/scvi/external/diagvi/_module.py 70.22% <70.22%> (ø)
src/scvi/external/diagvi/_base_components.py 43.65% <43.65%> (ø)
src/scvi/external/diagvi/_model.py 73.16% <73.16%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants