-
-
Notifications
You must be signed in to change notification settings - Fork 3
Small clarification to build instructions #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Okay now I've added a change in the sandstorm data sections that I'm a lot less confident about but if it's wrong I'd like to make a correct version of it. |
|
I'm gonna have a few more things. I just want to get through the installation and then I'll present all my suggestions. |
f97c3c5 to
542a87f
Compare
|
Okay, no longer a "small" clarification. Rename the issue if you'd like. Ready for review. I'll leave a few comments inline to clarify my intent. |
| - an extra directory at `sandstorm/mnt` | ||
| - a sqlite3 database at `sandstorm/sandstorm.sqlite3` | ||
| - a sqlite3 database at `/opt/sandstorm/var/sandstorm/sandstorm.sqlite3` | ||
| (that's it for now, we will try to update as things progress) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see a mnt anywhere but maybe it's because I didn't get far enough in running tempest.
| ``` | ||
| mkdir ../sandstormexport | ||
| ./_build/sandstorm-import-tool --snapshot-dir ../sandstormexport export | ||
| sudo -u sandstorm -g sandstorm ./_build/sandstorm-import-tool --snapshot-dir /tmp/sandstormexport export |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #5
README.md
Outdated
| ``` | ||
| sudo cp -r ./toolchain/go-* /usr/local/go | ||
| PATH="/usr/local/go/bin:$PATH" | ||
| go version # confirm that go is installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the idea is to have a local version of go, what about modifying $PATH and $GOPATH in the current session to point to the local toolchain, instead of copying this exe to the global location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, obviously that's the way to go. Though I'm not sure I need to change GOPATH, I assumed it would be pointing at ~/go. I'll try it.
Account for `make toolchain` and also make it a little more clear for a newcomer.
Give people a sense that things are in progress.
d53ad97 to
5f36904
Compare
Is all of this accurate? Though maybe we want to sort out these issues first:
Though I'm happy to put off 5 so long as this README is strictly better than it was previously.