-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Maintenance on PostgreSQL clients #3186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@kkimurak What do you think about this PR and the removal of old PostgreSQL client versions. I guess, we have to add a comment to the release notes. Otherwise it might be possible that a lot of users could run into trouble. |
|
I think it's ok to remove old PostgreSQL clients. In addition to release notes, how about displaying a warning (or terminating with an error) if the minimum and maximum version requirements are not met? By the way, according to the link, Maximum PostgreSQL version for GitLab 18.x is 17.x (tested against GitLab 17.10 and later) |
|
@kkimurak Nice idea and I'll take over your commits. However, since GitLab does not support PostgreSQL v18 so far not officially, we'll wait before publishing this branch. |
64d1b4e to
eb93420
Compare
eb93420 to
8fd8978
Compare
8fd8978 to
9e35700
Compare
9e35700 to
497d0d8
Compare
Without those changes puma (and then gitlab itself) does not starts See following upstream changes: - https://gitlab.com/gitlab-org/gitlab/-/merge_requests/128619 (overwritten by gitlab-org/gitlab!132581) - https://gitlab.com/gitlab-org/gitlab/-/merge_requests/132581 - https://gitlab.com/gitlab-org/gitlab/-/merge_requests/211331
497d0d8 to
e18d516
Compare
Since PostgreSQL v18 was already published we need to provide a suitable postgresql client as well.
However, following the requirements for GitLab CE and in particular for PostgreSQL (see https://docs.gitlab.com/18.5/install/requirements/#postgresql) we should remove all clients for PostgresSQL versions smaller than 16.