Skip to content

Cache submodule into git db #16246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avnyu wants to merge 8 commits into
base: master
Choose a base branch
from
+107 −76
Open

Cache submodule into git db #16246

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
69eeb23
extract code into GitSource::update_db
avnyu Nov 12, 2025
ffd78e6
recursive cache git submodules
avnyu Nov 12, 2025
65cb3b7
fix: error context position
avnyu Nov 12, 2025
3530ca4
Merge branch 'master' of https://github.com/rust-lang/cargo into cach…
avnyu Nov 27, 2025
ea4eb86
fix: print "updating git submodule" when database existed and already…
avnyu Nov 27, 2025
d4d3e6a
chore: break db.copy_to
avnyu Nov 27, 2025
aeda351
chore: put fetch submodule error context to source and update_db
avnyu Nov 27, 2025
8705c44
chore: fix typo
avnyu Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cargo/sources/git/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ impl<'a> GitCheckout<'a> {
format!("failed to fetch submodule `{name}` from {child_remote_url}",)
})?;

// Clone and reset to the head commmit
// Clone and reset to the head commit
Copy link
Member

@weihanglo weihanglo Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are open to rebasing/reorganizing your commit history throughout the iterations of a pull request. And personally I think this kind of commit should be squashed into wherever made this typo. That would help get a more understandable/traceable git commit history

let (_, guard) = GitCheckout::clone_into(&repo.path(), &db, actual_rev, gctx)
.with_context(|| {
let name = child.name().unwrap_or("");
Expand Down