Revert PR #2577: Restore support for return in endpoint blocks

[ericproulx]

Revert PR #2577: Restore support for return in endpoint blocks

Summary

This PR reverts the changes introduced in PR #2577 that deprecated the use of return in endpoint blocks and simplified endpoint block execution. Based on the discussion in PR #2577, we are restoring the previous behavior that allows return statements to work without deprecation warnings.

Background

PR #2577 ("Simplify endpoint block execution and deprecate return call in it") changed how endpoint blocks are executed by:

• Using instance_exec instead of converting blocks to unbound methods
• Catching LocalJumpError exceptions and issuing deprecation warnings when return was used
• Recommending the use of next instead of return

After further discussion, it was decided to revert these changes to maintain backward compatibility and restore the original behavior.

Changes

Endpoint Block Execution (lib/grape/endpoint.rb)

• Restored block_to_unbound_method class method: Converts blocks to unbound methods for proper return handling
• Restored unbound method binding: Changed from instance_exec(&@source) back to @source.bind_call(self)
• Removed deprecation warning: Removed the LocalJumpError rescue block that issued deprecation warnings for return statements

Tests (spec/grape/endpoint_spec.rb)

• Simplified return test: Removed deprecation warning expectations
• Removed next test: No longer needed since return is the supported approach again

Impact

• ✅ return statements in endpoint blocks now work without deprecation warnings
• ✅ Restores backward compatibility with existing codebases using return
• ✅ Maintains the same functionality as before PR Simplify endpoint block execution and deprecate return call in it #2577

Related

• Reverts: #2577 - Simplify endpoint block execution and deprecate return call in it

[ericproulx]

After this merge, we should release a 3.0.2.

[dblock]

Rebase, feel free to merge.