[cppyy] Enable tests on windows #18872
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 18h 5m 18s ⏱️ For more details on these failures, see this check. Results for commit 1e36c5e. ♻️ This comment has been updated with latest results. |
Contributor
2025-05-26T19:53:28.0200811Z 24: if sc == -1:
2025-05-26T19:53:28.0200984Z 24: > raise RuntimeError("Unable to load reflection library "+name)
2025-05-26T19:53:28.0201385Z 24: E RuntimeError: Unable to load reflection library C:\ROOT-CI\build\bindings\pyroot\cppyy\cppyy\test/stltypesDictLooks like we have to use a proper |
guitargeek
force-pushed
the
cppyy-win-tests
branch
2 times, most recently
from
6477723 to
7897153
Compare
guitargeek
force-pushed
the
cppyy-win-tests
branch
from
7897153 to
bff3898
Compare
guitargeek
force-pushed
the
cppyy-win-tests
branch
14 times, most recently
from
1a10344 to
46b7533
Compare
These files are unused.
They are now part of the cppyy tests that are run on all platforms. The only test that is kept is a ROOT-specific one, which is moved to a different file.
Using environment variables like `ROOTSYS` in the include paths stored in TSystem - which are used in ACLiC - is problematic if we want to move away from such environment variables. This commit suggests to figure out instead the actual `ROOTSYS` path with `gROOT->GetRootSys()`, and then fill it into the TSystem include path. The code is further simplified by using private preprocessor macros defined at compile time to pass around the `CMAKE_INSTALL_INCLUDEDIR`.
guitargeek
force-pushed
the
cppyy-win-tests
branch
from
46b7533 to
572f3a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger a verbose CI run with Windows to examine the cppyy test status