fix: initialize notification infra before first ticker tick #24049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanicky
requested review from
Copilot and
yezizp2012
and removed request for
Copilot
github-actions
bot
added
type/fix
shanicky
added
need-cherry-pick-since-release-2.7
and removed
type/fix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a concurrency bug in the stream scale manager by reordering initialization steps. The notification channel is now fully set up before the first ticker delay, preventing missed notifications during system startup.
- Moves
ticker.tick().awaitafter notification channel setup to prevent race conditions - Ensures notifications sent during the initial delay period are properly captured
- Follows the initialization pattern used in similar components (backup_manager, barrier_worker)
Move the first `ticker.tick().await` after setting up the notification channel and inserting it into the notification manager. This ensures the notification system is ready before the ticker advances. - Prevents missed notifications during initialization - Avoids races where channels are not set up in time - Improves reliability of async task startup - Addresses potential concurrency bug in stream scale manager Signed-off-by: Shanicky Chen <[email protected]>
shanicky
force-pushed
the
peng/fix-noti
branch
from
aedd57f to
3706958
Compare
github-actions
bot
added
type/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Move the first
ticker.tick().awaitafter setting up the notification channel and inserting it into the notification manager. This ensures the notification system is ready before the ticker advances.Checklist