Skip to content

Conversation

@huangkevin-apr
Copy link
Contributor

@huangkevin-apr huangkevin-apr commented Jan 22, 2026

Summary

This PR fixes 6 critical accessibility violations on website homepage identified by the IBM Equal Access Accessibility Checker, where interactive elements (links and buttons) containing only images/icons lacked accessible names, making them unusable for screen reader users.

Problems Identified

image

Issue 1: Logo Images Missing Alt Text (1 violations, blue box)

Violation: Hyperlink has no link text, label or image with a text alternative
Elements: Two tags within the homepage link (responsive logo variants)
Impact: Screen reader users cannot identify that these images are clickable links to the homepage or understand their purpose

Issue 2: Search Button Icon Missing Label (1 violation, red box)

Violation: SVG element has no accessible name
Element: Magnifier glass SVG icon within search button
Impact: Screen reader users cannot identify the button's purpose

Issue 3: Social Media Icon Links Missing Labels (4 violations, yellow box)

Violation: Hyperlink has no link text, label or image with a text alternative
Elements: GitHub, X (Twitter), Bluesky, and Discourse links containing only SVG icons
Impact: Screen reader users hear only "link" without any context about the destination

Solutions

Fix 1: Add Alt Text to Logo Images

Added descriptive alt="ReScript Home" attributes to both logo image variants, clearly indicating they link to the homepage.

Fix 2: Make Search Button Accessible

Added aria-label="Search" to the search button

Fix 3: Add Aria-Labels to Social Media Links

Added descriptive aria-label attributes to each social media link:

Testing

All icon elements have been added description text:
Screenshot of Fix After
image

Additional Info

The patch submitted in this PR was generated by A11YRepair, an automated Web Accessibility repair tool that I developed to address common accessibility violations in web applications.

Copy link
Member

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Copy link
Member

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but ariaLabel should be camelCased.

@huangkevin-apr
Copy link
Contributor Author

Thanks a lot!

It seems that there are some build errors, I will try to solve them. Thanks.

@huangkevin-apr
Copy link
Contributor Author

Sorry, but ariaLabel should be camelCased.

Thanks for your help. Now it should work.

@fhammerschmidt fhammerschmidt enabled auto-merge (squash) January 22, 2026 16:57
Copy link
Member

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fhammerschmidt fhammerschmidt merged commit a853ad0 into rescript-lang:master Jan 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants