Let getXMLSerializer raise XMLSyntaxError when passed empty iterable #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Then the result with
lxml6 is the same as it was withlxml5, instead of throwing anAttributeError. Alternatively, we could return None.See diazo PR 92 and especially this comment and the one after it.
If we change
repoze.xmliterin this way, it helps for Plone. But I am not sure if that is the best forrepoze.xmliteritself.Options I see:
XMLSyntaxErrorlike in this PR, return None instead. Needs a bit more changes in Plone, but they are not hard, and this may be a bit friendlier.repoze.xmlitercode, probably into thediazopackage, and adapts it to its needs. This is the most work, and needs a bit of discussion in Plone, but it may be the safest for other users ofrepoze.xmliter. Then my PR Switch to native namespace #22 would not be relevant to Plone anymore either, so I don't have to wait for that.I like the first or second option best.