NCL-9197 Add ability to import RPMs #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwalluck
reviewed
Jul 10, 2025
| */ | ||
| @StructPart | ||
| public class NpmTypeInfoExtraInfo | ||
| public class EmptyTypeInfoExtraInfo |
Member
There was a problem hiding this comment.
I think the fact that it is empty is just incidental. I'd rather see this class and the type information kept by just making another copy of this class.
Contributor
Author
rnc
commented
Jul 11, 2025
| return "FileExtraInfo{" + "npmExtraInfo=" + npmExtraInfo + "}"; | ||
| } | ||
| else if ( getMavenExtraInfo() != null ) | ||
| else if ( getTypeInfo() != null ) |
Contributor
Author
There was a problem hiding this comment.
Was duplicating a getMavenExtraInfo from line 149.
dwalluck
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.