add mcp metrics #3828
Open
add mcp metrics #3828
+131
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alenkacz
force-pushed
the
av/metrics-mcp
branch
from
15fad5b to
b4c5f14
Compare
Use the official go-sdk middleware infrastructure (AddReceivingMiddleware) instead of manual instrumentation. This tracks all MCP method calls and provides detailed tool-specific metrics (invocations, duration, sizes, errors) across all transports (stdio, SSE, streamable HTTP).
alenkacz
force-pushed
the
av/metrics-mcp
branch
from
b4c5f14 to
9815ec5
Compare
Author
|
@rockwotj claude made the updates, can you check it out? :) |
rockwotj
reviewed
Dec 9, 2025
internal/mcp/metrics/metrics.go
Outdated
| @@ -0,0 +1,131 @@ | |||
| // Copyright 2024 Redpanda Data, Inc. | |||
internal/mcp/metrics/metrics.go
Outdated
Comment on lines
109
to
110
| m.toolInvocations.Incr(1, toolName, "error") | ||
| m.toolErrors.Incr(1, toolName, "invocation_error") |
Contributor
There was a problem hiding this comment.
I don't understand why we need both metrics here
Author
|
@rockwotj addressed |
rockwotj
reviewed
Dec 10, 2025
alenkacz
force-pushed
the
av/metrics-mcp
branch
from
9c6bcfe to
75f1db6
Compare
alenkacz
force-pushed
the
av/metrics-mcp
branch
from
75f1db6 to
4b3edc8
Compare
Author
|
@rockwotj okay, 🤞 now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.