add support to elasticsearch/v9 #3813
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main intent of this PR is allow this internal improvement:
https://github.com/elastic/go-elasticsearch/blob/main/CHANGELOG.md#typed-api-1
to use it, we can just change the yaml tag and use the output
elasticsearch_v9, should be backward compatible with the v8 taghowever, since we may keep elasticsearch v8 and v9 for a while, we may not benefit immediately from the dead code elimination but the main development today is on v9, it support earlier versions of go and I think we should consider add support on it.
since both codes are very similar, I did not try create like a "base" package to reuse the logic, but I can do if needed (or in another PR)
Regards