DOC-6225 add underscore to embeds folder to prevent publication #2729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
|
I tagged @cmilesb and @rrelledge directly for reviews because they use embeds all the time. |
Collaborator
|
@andy-stark-redis Are you sure the underscore prevents publication? I can access https://redis.io/docs/staging/DOC-6225-dont-publish-embeds/_embeds/supported-platforms-embed/ still. |
Collaborator
|
Maybe @paoloredis can help with this? There's probably a way to exclude the embeds somewhere in the build process/GitHub workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it's not in the navigation, the
embedsfolder was being published. This stuff doesn't make sense by itself and could easily contain obsolete material, so it seems best not to publish it. The easiest way to do this was to renameembedsto_embeds(underscore prevents publication).I've checked a few examples of embedded content to make sure they still work following this change (no need to change pathnames or shortcodes for this, btw). It looks OK to me, but if there are any places where things could go wrong because of this change, then please let me know :-)