chore(ci): revert log in reporting.sh #3813
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Contributor
|
The image is available at: |
gustavolira
added a commit
to gustavolira/rhdh
that referenced
this pull request
Dec 5, 2025
Add log::*_stdout() functions to lib/log.sh for special cases where output must be written to stdout instead of stderr. This fixes the Slack notification system in reporting.sh which parses stdout. Changes: - Add log::emit_line_stdout() and log::emit_stdout() core functions - Add log::debug_stdout(), log::info_stdout(), log::warn_stdout(), log::success_stdout() convenience functions - Update reporting.sh to use *_stdout variants for all log calls The *_stdout variants maintain the same formatting, colors, and log level filtering as the standard log functions, but write to stdout instead of stderr to ensure compatibility with external parsers. Related: redhat-developer#3813
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert the use of new log class in
reporting.shto fix errors like this: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-redhat-developer-rhdh-main-e2e-ocp-helm-nightly/1996973958125064192#1:build-log.txt%3A4890Because the the pipeline script relies on this:
The long term solution would be to move the scripts directly to the pipeline scripts at openshift/release to reduce the complexity and interconnection between the repositories, or to source also the lib directory.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer