Skip to content

Conversation

@adrianriobo
Copy link
Collaborator

This PR will include changes on the tekton task specs to run mapt.

Fix #294
Fix #329

@adrianriobo adrianriobo force-pushed the fix-329 branch 10 times, most recently from beb6e2a to 61f0428 Compare November 13, 2024 15:04
@adrianriobo adrianriobo added this to the v0.8.0 milestone Dec 9, 2024
@adrianriobo adrianriobo changed the title WIP: Mapt Konflux Compliant Mapt Konflux Compliant Dec 9, 2024
@adrianriobo adrianriobo force-pushed the fix-329 branch 5 times, most recently from d1f6ec9 to 2c2101f Compare December 9, 2024 12:45
@anjannath
Copy link
Collaborator

@adrianriobo need to rebase this, sorry i think merging the dependencies update PR caused the merge conflict here!

@adrianriobo
Copy link
Collaborator Author

@anjannath sure it is fine np

@adrianriobo adrianriobo force-pushed the fix-329 branch 2 times, most recently from 7052d3e to 4898da3 Compare December 10, 2024 08:56
@lilyLuLiu
Copy link
Collaborator

lilyLuLiu commented Feb 14, 2025

During test of using the tekton on pipeline, I met an issue:

  • there are three provision tasks(rhel, fedora, windows) in parallel in the pipeline. One of them will execute to provision machine according to pipeline parameter.
  • Then the sync job will gather the host info according to the result of provision job.
  • But as the secret name of host info is different from different provision task. The sync job can't get the host info. (using task parameter is not working)

@adrianriobo As we discuss, it's better that the mapt tkn could have a parameter to specify the secret name.

@adrianriobo
Copy link
Collaborator Author

^^ @lilyLuLiu changed based on comments

@adrianriobo adrianriobo force-pushed the fix-329 branch 2 times, most recently from 93f924a to af7cb62 Compare February 26, 2025 07:48
@adrianriobo adrianriobo changed the title Mapt Konflux Compliant WIP: Mapt Konflux Compliant Feb 26, 2025
@adrianriobo
Copy link
Collaborator Author

Set as WIP as we need to remove the latest commit before merge, the commit will allow to test the tekton tasks based on this commit

@adrianriobo adrianriobo moved this from Hold to Ready for review in Project planning: crc Feb 26, 2025
@lilyLuLiu
Copy link
Collaborator

@adrianriobo What the value of parameter vmsize should be in tkn/infra-azure-windows-desktop.yaml?

In pipeline, the default value was set as Standard_D8ds_v4. But during test, mapt failed due to this value.
https://console-openshift-console.apps.gpc.ocp-hub.prod.psi.redhat.com/k8s/ns/devtoolsqe--pipeline/tekton.dev~v1~PipelineRun/mapt-test-2.47.0-windows10-22h2-ent-jjsd4/logs?taskName=provision-windows

@lilyLuLiu
Copy link
Collaborator

@adrianriobo The parameter host-access-secret-name not work for infra-aws-rhel.yaml during test.

I input value host-info-$(tasks.correlate.results.correlation) for the parameter. But the output secret name ismapt-aws-rhel-f9d6s

@adrianriobo
Copy link
Collaborator Author

For vmsize now you do not need to set the value, it will pick a valid one for you what you need to set is the nested-virt to true.

@adrianriobo
Copy link
Collaborator Author

For the aws rhel I missed the code, now it is added so it should work as expected 🤞

@lilyLuLiu
Copy link
Collaborator

@adrianriobo Thanks, the rhel tkn works well now. But I found that infra-azure-windows-desktop.yaml has the same issue.
Parameter host-access-secret-name is not working.

@adrianriobo
Copy link
Collaborator Author

@lilyLuLiu ok, checked all of them....not sure what happened...now they should be fine

Previously mapt weas using workspaces as input spaces for cloud credentials this could be done by using more basic components from k8s volumes, also the resulting information to connect within the provisioned machine / service was return as a combination of plain results and stored files on location from workspaces. this commit will change the approach to create a specific secret holding the information as another basic resources offered by k8s

Signed-off-by: Adrian Riobo <[email protected]>
@adrianriobo adrianriobo force-pushed the fix-329 branch 2 times, most recently from c2ac83e to 4420351 Compare March 3, 2025 08:23
@adrianriobo adrianriobo merged commit c1e0082 into redhat-developer:main Mar 3, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Done in Project planning: crc Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Go back from Workspaces to Volumes to increase compatibility Return host-info as secret ref

3 participants