-
Notifications
You must be signed in to change notification settings - Fork 24
WIP: Mapt Konflux Compliant #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
beb6e2a to
61f0428
Compare
d1f6ec9 to
2c2101f
Compare
|
@adrianriobo need to rebase this, sorry i think merging the dependencies update PR caused the merge conflict here! |
|
@anjannath sure it is fine np |
7052d3e to
4898da3
Compare
|
During test of using the tekton on pipeline, I met an issue:
@adrianriobo As we discuss, it's better that the mapt tkn could have a parameter to specify the secret name. |
|
^^ @lilyLuLiu changed based on comments |
93f924a to
af7cb62
Compare
|
Set as WIP as we need to remove the latest commit before merge, the commit will allow to test the tekton tasks based on this commit |
|
@adrianriobo What the value of parameter In pipeline, the default value was set as |
|
@adrianriobo The parameter I input value |
|
For |
|
For the aws rhel I missed the code, now it is added so it should work as expected 🤞 |
|
@adrianriobo Thanks, the rhel tkn works well now. But I found that |
|
@lilyLuLiu ok, checked all of them....not sure what happened...now they should be fine |
Previously mapt weas using workspaces as input spaces for cloud credentials this could be done by using more basic components from k8s volumes, also the resulting information to connect within the provisioned machine / service was return as a combination of plain results and stored files on location from workspaces. this commit will change the approach to create a specific secret holding the information as another basic resources offered by k8s Signed-off-by: Adrian Riobo <[email protected]>
c2ac83e to
4420351
Compare
This PR will include changes on the tekton task specs to run mapt.
Fix #294
Fix #329