Re Enable assembly signing #2033
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated InternalsVisibleTo attributes to include public keys.
InternalsVisibleTo attributes in AssemblyInfo.cs and API approval snapshots for .NET 8, 9, and 10 have been updated to include explicit public keys. This change improves assembly security and compatibility with strong-named assemblies.
Changed InternalsVisibleTo attributes in ApiApprovalTests.Refit.DotNet10_0.verified.txt to include public keys. Removed the received snapshot file to reflect updated API approval state.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 35 35
Lines 2662 2662
Branches 383 383
=======================================
Hits 2208 2208
Misses 360 360
Partials 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
What is the current behavior?
#2030
What is the new behavior?
This pull request makes a small but important change to the project build configuration by re enabling assembly signing.
Directory.Build.props: Set<SignAssembly>totrue(was previously commented out), ensuring that assemblies are signed during the build process.What might this PR break?
Fixes accidental commenting of Signing
Please check if the PR fulfills these requirements
Other information: