Skip to content

Conversation

@aslonnie
Copy link
Collaborator

stop using python 3.9

@aslonnie aslonnie requested a review from a team as a code owner December 10, 2025 19:57
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Dec 10, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the Kubernetes tests to use Python 3.10 by updating the base images and adding the --python-version 3.10 flag to the bazel commands. The changes are consistent and well-targeted.

I have one suggestion for improving maintainability by reducing code duplication in ci/k8s/run-operator-tests.sh.

Additionally, I noticed a potential omission: in ci/k8s/run-operator-tests.sh, the bazel run //ci/ray_ci:build_in_docker command on line 8 is missing the --python-version 3.10 flag. This might cause the test image to be built with an incorrect Python version. For consistency with ci/k8s/run-chaos-test.sh, you might want to add this flag.

@aslonnie aslonnie force-pushed the lonnie-251210-k8sbase branch 2 times, most recently from 0dcdab9 to 4ee3ca7 Compare December 10, 2025 22:28
stop using python 3.9

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie enabled auto-merge (squash) December 11, 2025 00:18
@aslonnie aslonnie merged commit cc9b7f6 into master Dec 11, 2025
8 checks passed
@aslonnie aslonnie deleted the lonnie-251210-k8sbase branch December 11, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants