Fix node-forge ASN.1 validation bypass vulnerability (CVE-2025-12816) #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override node-forge to version 1.3.2 to address a security vulnerability in versions 1.3.1 and below. The vulnerability allowed ASN.1 validation bypass which could compromise cryptographic verifications. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
|
Copilot finished reviewing on behalf of
brynary
November 29, 2025 03:31
There was a problem hiding this comment.
Pull request overview
This pull request addresses CVE-2025-12816 by overriding the node-forge dependency to version 1.3.2, which fixes an ASN.1 validation bypass vulnerability. The package is used transitively through @devicefarmer/adbkit, a dependency of web-ext.
Key Changes:
- Added npm override for
node-forgeto version 1.3.2 in package.json - Updated package-lock.json to reflect the new node-forge version
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Added node-forge override to version 1.3.2 alongside existing pino override |
| package-lock.json | Updated node-forge version and metadata, but contains erroneous peer dependency markers on multiple packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
node-forgedependency to version 1.3.2 to address CVE-2025-12816Changes
node-forgeto1.3.2inpackage.jsonpackage-lock.jsonwith the new resolved versionTest plan
npm installcompletes successfullynpm run buildcompletes without errorsnode-forgeversion is 1.3.2 in node_modules🤖 Generated with Claude Code