-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 817: Wheel Variants: Beyond Platform Tags #4740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Oh thanks @hugovk I totally didn't see that one being published within 20min :D Let me know which number you want me to pick and I'll do the update ;) |
|
Thanks! @DEKHTIARJonathan You may continue with 817. |
AA-Turner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very brief review, I haven't yet read beyond the end of Motivation.
A
|
Just a brief bystander comment: I'm so stoked to see this PEP draft published! |
Co-authored-by: Adam Turner <[email protected]>
Thanks Jannis! Took some significant amount of work but we eventually got there |
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
e34e8fa to
64f32ed
Compare
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Reflow the text to restore correct text width after all the inline changes and applied suggestions. Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Remove accidental double spaces that vim's `gq` introduced while I was reflowing the text. Thanks to @konstin for noticing. Signed-off-by: Michał Górny <[email protected]>
| enabling the optional provider or selecting the variant explicitly. | ||
|
|
||
|
|
||
| Package ABI matching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super excited about this one by the way :D
|
@willingc I think you're familiar with the genesis of the work and context. Maybe skip over that for a start. I would start from We tried extremely hard to keep the PEP as precise and short as possible specifically on the So any help to make the PEP easier to read / understand / shorter is good to take. |
|
I'd also like to highlight the difference between the normative and the non-normative section. The normative section is meant to eventually go to packaging.python.org, while the non-normative section is for the PEP discussion on why we're proposing such a big new feature, who needs it and to share the trade-offs we made in design decisions. It's has become really long, since we had a lot of input from a lot of projects and capture more the current state than the future we propose. Similar to the other packaging PEPs, I expect the non-normative part to become a historical document, while the normative is what really needs to be written unambiguously and future-proof. |
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Pending further rewrite. Signed-off-by: Michał Górny <[email protected]>
|
I went through all the comments, and I think I've addressed them in wheelnext#32 and wheelnext#33. We'll update this PR when other authors review these changes. |
Signed-off-by: Michał Górny <[email protected]>
To make it easier to edit sections without having to move initial definitions around. Signed-off-by: Michał Górny <[email protected]>
These additional projects are listed without any explanation, so let's just defer to specific examples in the "current workarounds ..." section. Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
This roughly repeats the introduction to motivation, and focuses on solution rather than the problem. Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
This reverts commit 261704f. Signed-off-by: Michał Górny <[email protected]>
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-HistoryCC: @mgorny @konstin @rgommers @atalman @charliermarsh @msarahan @seemethere @warsaw @dstufft @aterrel
📚 Documentation preview 📚: https://pep-previews--4740.org.readthedocs.build/pep-0817/