gh-138061: Exclude __pycache__ directory from the computed digest in the jit stencils #138131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonme
requested review from
brandtbucher,
diegorusso and
savannahostrowski
as code owners
alonme
commented
Aug 25, 2025
diegorusso
approved these changes
Aug 26, 2025
Contributor
diegorusso
left a comment
diegorusso
left a comment
There was a problem hiding this comment.
Thanks! LGTM but I'd like a second opinion on it.
Contributor
|
I'm also 50/50 for the news file. Let's wait a second opinion. |
Contributor
|
I tested this change and it helped. |
diegorusso
changed the title
Contributor
|
Ok, let's try to progress this. Can you create a news file? Click on bedevere/news in the failed checks and follow the instructions. Focus more on the purpose of the PR from the user point of view. |
Contributor
Author
|
@diegorusso Thanks for reviews, |
brandtbucher
approved these changes
Aug 30, 2025
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…st in the JIT stencils (python#138131) Exclude the __pycache__ directory when generating the digest in the JIT stencils
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Sep 12, 2025
https://build.opensuse.org/request/show/1304274 by user dgarcia + anag_factory - Add gh138131-exclude-pycache-from-digest.patch fixing reproducible build for python-nogil. (bsc#1244680, gh#python/cpython#138131)
savannahostrowski
added
needs backport to 3.13
|
Thanks @alonme for the PR, and @diegorusso for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @alonme for the PR, and @diegorusso for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 9, 2025
…st in the JIT stencils (pythonGH-138131) Exclude the __pycache__ directory when generating the digest in the JIT stencils (cherry picked from commit d3d94e0) Co-authored-by: alm <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 9, 2025
…st in the JIT stencils (pythonGH-138131) Exclude the __pycache__ directory when generating the digest in the JIT stencils (cherry picked from commit d3d94e0) Co-authored-by: alm <[email protected]>
|
GH-142481 is a backport of this pull request to the 3.13 branch. |
|
GH-142482 is a backport of this pull request to the 3.14 branch. |
savannahostrowski
pushed a commit
that referenced
this pull request
Dec 9, 2025
…est in the JIT stencils (GH-138131) (#142481) Co-authored-by: alm <[email protected]>
savannahostrowski
pushed a commit
that referenced
this pull request
Dec 9, 2025
…est in the JIT stencils (GH-138131) (#142482) Co-authored-by: alm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #138061