Fix: Default Mode In show_dash Causes TypeError #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to address the following bug.
Describe the bug 🖍️
When calling
FigureResampler.show_dash()without specifying mode, the method raisesTypeError: argument of type 'NoneType' is not iterable. Full error message isReproducing the bug 🔍
Expected behavior 🔧
The figure opens in "external" mode, according to the
show_dashdocstring.Environment information: (please complete the following information)
Additional context
The cause of the error is in the line
if "inline" in mode and height_param not in kwargs:, which doesn't work whenmodedefaults toNonebut is regarded as a string here. We can fix this by settingmodeto "external" before this line.