Add option to mirror stacking direction with mirror mod (and rank mirrored stacks) #36115
+60
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
!diffcalc |
Contributor
|
!diffcalc |
Contributor
Author
|
made this branch https://github.com/TextAdventurer12/osu/tree/mirror-stacks-diffcalc-check to check that the reversed stacks give the same sr (adds reversed stack mirror to every map without the mirror mod during diffcalc). Couldn't manage to get a full sheet working locally, but just manually looking around with osu-tools showed no real sr changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29327
Partially resolves #33076 (fully resolved in #29324 but relies on real-time difficulty)
I think a toggle is going to make the most people happy since people are clearly divided on whether or not they want mirror to change stacking direction, so providing both options means people can just pick whatever they want.
Mirror currently isn't ranked because of differences in sr due to stacking, which don't exist with stacking direction changing so the mod should be fine to be ranked with reflected stacks