Skip to content

Conversation

@43081j
Copy link
Contributor

@43081j 43081j commented Sep 21, 2025

This is exactly what is in #455 but with the tests fixed.

I can't push to Ben's branch. So feel free to merge this one or merge it into Ben's branch and merge that.

benmccann and others added 5 commits September 15, 2025 09:18
fast-glob is poorly designed and foolishly varies its return type based
on if the cwd is absolute or not. This is nonsense. Thankfully,
tinyglobby doesn't do it, but we need to abs everything in that case.
@43081j
Copy link
Contributor Author

43081j commented Sep 21, 2025

alright windows, as per usual, is falling over

ill sort it some other time. its late here 😅

@43081j 43081j force-pushed the tinyglobby-fix branch 2 times, most recently from 109662b to ef447b2 Compare September 23, 2025 10:04
@43081j
Copy link
Contributor Author

43081j commented Sep 23, 2025

alright because a whole raft of nonsense changed since i touched this, here's a summary:

  • tinyglobby returns unix paths while globby returns windows paths
    • i've updated isUnder to unixify the base path before comparing
  • globby returns relative paths if the input glob is relative, and absolute paths if it is absolute
    • i've updated cwd to always be absolute
    • i've set absolute: true so glob results are always absolute too
    • resolvePath expects a relative path so i've ensured we always calculate the relative one from the absolute path

@crutchcorn this should be good now. ping me if you have questions as i realise its no longer a straightforward diff

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@crutchcorn crutchcorn merged commit 4635ce8 into plopjs:main Sep 26, 2025
4 checks passed
@43081j 43081j deleted the tinyglobby-fix branch September 26, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants