Translate code on english #69

zabidenhtf · 2026-01-13T13:12:00Z

No description provided.

petitlapin · 2026-01-13T19:59:02Z

Thanks for the PR (and the other one in Li-ri-devel). As said in another issue, bumping the year is clearly not the most important for now (as there is no release planned for now).
I'll keep them open and will merge them later when I plan to do a release.

How much do you want to work on improving the game? On my side, I mostly plan to only do minor changes and keep it alive and up-to-date, so I don't have big plans to add new features or major improvements. I've opened a few ideas that could help with the maintenance (such as using sdl_ttf for the texts instead of images, because as you saw, generating the data is complicated and if we want to add languages, it will not be easy or more easy or having the option to not have the human rights questions). Is it something you'd like to work on?
Because if that's the case, I can see to prioritize on my side to fix the issues of non English texts which are blockers to contribute.

zabidenhtf · 2026-01-14T08:01:56Z

Yes, I’m interested in helping in Li-Ri project. I see potential in this project. :D

zabidenhtf · 2026-01-14T16:21:42Z

Hello, I have a small question would you be able to merge my PR?

petitlapin · 2026-01-14T18:02:55Z

Hello, I have a small question would you be able to merge my PR?

Regarding the copyright, I think I'll prefer to do it myself when I'll want to create a new release: the main point is that for the image you didn't use the same font, so I would like to ensure I use the same one as before.
Can you please rename this PR only for renaming and delete the commit regarding the copyright? Then, I'll be able to review it (and please, note it may take some time, I'm working on multiple projects and in real life so I don't have a lot of time for Li-Ri)

petitlapin · 2026-01-14T18:03:33Z

src/utils.h


    static bool LoadPref(); // Load preferences
-    static void SauvePref(); // Save preferences
+    static void SavePref(); // Save preferences


I would go with SavePreferences() and remove the comment (ideally same for LoadPreferences above)

src/preference.h

petitlapin · 2026-01-14T18:10:09Z

src/main.cc

-Level level; // Gère les niveaux
+Sprite *Sprites = nullptr; // Sprites pointer
+int NSprites = 0; // Number of sprites in memory
+Screen Ec; // 2 Video buffer pointer TODO: RENAME


would be nice if we can remove the TODO. Maybe call it screens (Ec is short for Ecran which is a screen in English)

and in my opinion will be good rename this object to screenObj

what does the "Obj" suffix bring?
Also, it would be better to avoid using acronyms or abbrevations if possible because the code is more often read than written, so even if you gain a few seconds by not typing the full word, people who will read the code will lose more time trying to understand its meaning

src/main.cc

zabidenhtf · 2026-01-15T07:05:50Z

Ok, I'm will fix my errors

zabidenhtf · 2026-01-15T09:07:15Z

Fixed

…stuff)

zabidenhtf · 2026-01-15T09:14:01Z

Hello, im removed copyright update from repository.

petitlapin · 2026-01-16T10:56:36Z

src/audio.cc

            return;
        }
-        MemoHorloge = Horloge;
+        MemoHorloge = currentTime;


can MemoHorloge be renamed memorizedTime?

Yes, sure :D

petitlapin · 2026-01-16T11:00:03Z

src/sprite.cc

    if (AfficheC == true) {
        Hor = SDL_GetTicks();
-        i = (Hor / (1000 / 25)) % Sprites[chargeur].N; // Calcule le numéro su sprite à afficher
+        i = (Hor / (1000 / 25)) % Sprites[digits].N; // Calcule le numéro su sprite à afficher


it should be loading here and everywhere below where it was chargeur (I don't add a comment for each, please double check all the file :))

Opps, im fix it

zabidenhtf · 2026-01-16T13:23:50Z

Fixed bug. now there no errors (and im fix critical bug with loading screen)

zabidenhtf · 2026-01-17T15:31:41Z

Hello, im have small question: when will be merged my PR?

petitlapin · 2026-01-18T10:00:34Z

Hello, im have small question: when will be merged my PR?

I'm copying what I wrote above: "please, note it may take some time, I'm working on multiple projects and in real life so I don't have a lot of time for Li-Ri"

You have to consider:

I have a life aside of the project so I don't have as much time as you would expect. So it may take a day or a week depending on what I have to do aside.
You probably did most of the change with an AI or an automatic translator (because you're Ukrainian and the probability of not being fluent in both English and French is really high 😄) but on my side I have to check every translation one by one and ensure there is no regression and it's really the initial meaning (which may be difficult to understand too). And reviewing this number of change takes time.
I have to consider how much strict I am with the changes: there are some small mistakes, do I take the time to ask you to change all of them (which will bore you at some point), do I merge the PR with these issues, do I want to fix them myself later?

So please, don't get me wrong, I really like your enthusiasm and willingness to improve this game and I hope you will be patient enough to let me the time to review the change and we can discuss the future of the game!

petitlapin · 2026-01-18T10:38:16Z

Can you please apply the attached patch? The small changes are:

comply with clang-format (change in game.cc)
fix the translation in menu.cc (I guess you changed all the "affiche" to "draw" but it was also used on comments and the remaining part of the sentence was kept in French)
rename DrawL to shouldDrawLoading, this way we don't need to find what is "L" and there is no more comment needed as the variable is self-explanatory.

To apply the patch, copy the file in the root folder and run: git apply patch.diff
patch.txt

Once applied, I'll run again the CI, clang-format should be green, and I'll squash and merge the PR :)

zabidenhtf · 2026-01-19T05:33:44Z

Ok, sure, but later

zabidenhtf · 2026-01-19T13:06:25Z

Fixed

zabidenhtf changed the title ~~Update copyright's to 2026~~ Update copyright's to 2026 and renamed some stuff in code Jan 14, 2026

petitlapin reviewed Jan 14, 2026

View reviewed changes

zabidenhtf added 5 commits January 15, 2026 11:12

Renamed timer on english, and renamed preferences (and a bit another …

b381718

…stuff)

More translation's in preferences

ecbbaf9

Fixed some translation moments

e2c7537

Renamed sprites to english

d9074cd

Renamed cargo wagon too

b7e9f6c

zabidenhtf force-pushed the main branch from b752bfe to b7e9f6c Compare January 15, 2026 09:12

zabidenhtf changed the title ~~Update copyright's to 2026 and renamed some stuff in code~~ Rename code on english Jan 15, 2026

zabidenhtf changed the title ~~Rename code on english~~ Translate code on english Jan 15, 2026

More translation fixes

331b12c

petitlapin requested changes Jan 16, 2026

View reviewed changes

Fixed critical bug with loading animation

f284707

zabidenhtf added 2 commits January 16, 2026 16:27

Renamed GFX stuff in code (Like draw functions)

164583c

Fixed small error Lenght->Length

9420847

Applied patch. Bit of fixes

b1859fc

Translate code on english #69

Are you sure you want to change the base?

Translate code on english #69

Conversation

zabidenhtf commented Jan 13, 2026

Uh oh!

petitlapin commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zabidenhtf commented Jan 14, 2026

Uh oh!

zabidenhtf commented Jan 14, 2026

Uh oh!

petitlapin commented Jan 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zabidenhtf commented Jan 15, 2026

Uh oh!

zabidenhtf commented Jan 15, 2026

Uh oh!

zabidenhtf commented Jan 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zabidenhtf commented Jan 16, 2026

Uh oh!

zabidenhtf commented Jan 17, 2026

Uh oh!

petitlapin commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petitlapin commented Jan 18, 2026

Uh oh!

zabidenhtf commented Jan 19, 2026

Uh oh!

zabidenhtf commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

petitlapin commented Jan 13, 2026 •

edited

Loading

petitlapin commented Jan 18, 2026 •

edited

Loading