Address issue #788 in vacuum. #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveshanley/vacuum#788 Added a new `RenderingMode` that is backwards compatible, allows for validation mode or bundling mode and only really affects discrimators and polymorphic schemas. The rendering context is now available in the `DynamicValue` object.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
=======================================
Coverage 99.59% 99.60%
=======================================
Files 189 189
Lines 22649 22671 +22
=======================================
+ Hits 22558 22582 +24
+ Misses 57 56 -1
+ Partials 34 33 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
daveshanley/vacuum#788
Added a new
RenderingModethat is backwards compatible, allows for validation mode or bundling mode and only really affects discrimators and polymorphic schemas.The rendering context is now available in the
DynamicValueobject.