Skip to content

Conversation

@mastro993
Copy link
Contributor

Short description

This PR fixes an issue on Android where, after a CIE reading failure, the CIE would be detected again without restarting the identification flow.

List of changes proposed in this pull request

  • Added CieManager.stopReading() inside error handler

How to test

This PR must be tested on Android

  • During the CIE identification step of the PID issuance flow, trigger a failure (e.g. remove the NFC tag).
  • Verify that, after the failure, the CIE is no longer detected.
  • Confirm that the CIE is detected again only after manually restarting the flow.

@github-actions
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.95%. Comparing base (9b4b095) to head (0d14d46).

Files with missing lines Patch % Lines
...twallet/identification/cie/hooks/useCieManager.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7737      +/-   ##
==========================================
- Coverage   59.95%   59.95%   -0.01%     
==========================================
  Files        1910     1910              
  Lines       41828    41829       +1     
  Branches     9712     9707       -5     
==========================================
  Hits        25078    25078              
- Misses      16665    16678      +13     
+ Partials       85       73      -12     
Files with missing lines Coverage Δ
...twallet/identification/cie/hooks/useCieManager.tsx 1.78% <0.00%> (-0.04%) ⬇️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4b095...0d14d46. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an Android-specific issue where NFC listening would continue after a CIE reading failure, causing the card to be detected again without manually restarting the identification flow.

Key Changes:

  • Added CieManager.stopReading() call in the error handler to stop NFC listening when a CIE read error occurs
  • Updated the cleanup handler's stopReading() call to include proper error handling with .catch()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant