-
Notifications
You must be signed in to change notification settings - Fork 114
fix(IT-Wallet): [SIW-3585] Stop listening NFC on CIE read error #7737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(IT-Wallet): [SIW-3585] Stop listening NFC on CIE read error #7737
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7737 +/- ##
==========================================
- Coverage 59.95% 59.95% -0.01%
==========================================
Files 1910 1910
Lines 41828 41829 +1
Branches 9712 9707 -5
==========================================
Hits 25078 25078
- Misses 16665 16678 +13
+ Partials 85 73 -12
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an Android-specific issue where NFC listening would continue after a CIE reading failure, causing the card to be detected again without manually restarting the identification flow.
Key Changes:
- Added
CieManager.stopReading()call in the error handler to stop NFC listening when a CIE read error occurs - Updated the cleanup handler's
stopReading()call to include proper error handling with.catch()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Short description
This PR fixes an issue on Android where, after a CIE reading failure, the CIE would be detected again without restarting the identification flow.
List of changes proposed in this pull request
CieManager.stopReading()inside error handlerHow to test
This PR must be tested on Android