feat: prefer-optional-chaining #484
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which helps test speed
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
kalvenschraut
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disclaimer this PR's code was generated entirely using opencode and claude opus 4.5. It has taken a lot of prompting on my end to get it into this state which I believe is a working on. I am not entirely sure how I would be able to test this on my ts codebase. I assume something with pnpm link would be possible?
I had it try look into reasons why my tests were so much slower and it found 1b11bfc to be one of the main reasons since the host in this repo has caching while ts go doesnt to my understanding.
I plan to review this over next week and test it out before I mark this as fully ready for external review but want to get some initial feedback if this was even the right direction / major glaring issues with the AI code.
Pretty excited about the speed increases from this as it is a major pain point in my company's code base and this rule and at least one other prefer nullish coalescing would be ones I wanted added asap so decided to try do it with opencode in my free time