Skip to content

Conversation

@Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Oct 15, 2025

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #199 will degrade performances by 2.25%

Comparing 10-15-chore_relax_the_set_sources_type_bound (1db4883) with main (ee503c4)

Summary

⚡ 1 improvement
❌ 2 regressions
✅ 2 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
generate_lookup_table 1.3 µs 1.3 µs -2.25%
to_json 5.6 µs 5.5 µs +1.06%
add_name_add_source_and_content 1.5 µs 1.6 µs -1.86%

@Brooooooklyn Brooooooklyn changed the title chore: relax the set_sources type bound chore: loosen the type constraint on set_sources Oct 15, 2025
@Brooooooklyn Brooooooklyn force-pushed the 10-15-chore_relax_the_set_sources_type_bound branch from 92ec2b7 to 71685fd Compare October 15, 2025 02:22
@Brooooooklyn Brooooooklyn force-pushed the 10-15-chore_relax_the_set_sources_type_bound branch from 71685fd to 1db4883 Compare October 15, 2025 02:23
@Brooooooklyn Brooooooklyn requested a review from Boshen October 15, 2025 02:23
@Boshen Boshen merged commit 405634f into main Oct 15, 2025
7 checks passed
@Boshen Boshen deleted the 10-15-chore_relax_the_set_sources_type_bound branch October 15, 2025 05:11
@Boshen Boshen mentioned this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants