Skip to content

Conversation

@Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Oct 15, 2025

Calculating the exact segments here is unnecessary because the other parts are also estimating for the worst case. Let's simply remove the debug_assert and increase the worst-case estimate.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen merged commit f9a57ac into main Oct 15, 2025
6 checks passed
@Boshen Boshen deleted the 10-15-fix_remove_debug_assert_in_sourcemap_encoding branch October 15, 2025 02:17
This was referenced Oct 15, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #197 will improve performances by 5.59%

Comparing 10-15-fix_remove_debug_assert_in_sourcemap_encoding (9a2f3bf) with main (16e16b0)

Summary

⚡ 3 improvements
✅ 2 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
to_json 5.7 µs 5.6 µs +1.55%
to_json_string 5 µs 5 µs +1.16%
add_name_add_source_and_content 1.7 µs 1.6 µs +5.59%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect debug assert

3 participants