Skip to content

Conversation

@syan212
Copy link

@syan212 syan212 commented Dec 7, 2025

Details

Comments

scripts/agent.mjs:139: propogates => propagates
scripts/bootstrap.sh:453: betwen => between
scripts/label-issue.ts:289: compatiblity => compatibility
scripts/machine.mjs:1196: polution => pollution

Variable names

scripts/runner.node.mjs:2178: delimeter => delimiter
scripts/runner.node.mjs:2179: delimeter => delimiter
scripts/runner.node.mjs:2179: delimeter => delimiter
scripts/utils.mjs:111: delimeter => delimiter
scripts/utils.mjs:112: delimeter => delimiter
scripts/utils.mjs:112: delimeter => delimiter

What does this PR do?

Corrects some spelling mistakes in scripts/

How did you verify your code works?

All changes did not affect actual functionality,

Details:
Comments
scripts/agent.mjs:139: propogates => propagates
scripts/bootstrap.sh:453: betwen => between
scripts/label-issue.ts:289: compatiblity => compatibility
scripts/machine.mjs:1196: polution => pollution
Variable names
scripts/runner.node.mjs:2178: delimeter => delimiter
scripts/runner.node.mjs:2179: delimeter => delimiter
scripts/runner.node.mjs:2179: delimeter => delimiter
scripts/utils.mjs:111: delimeter => delimiter
scripts/utils.mjs:112: delimeter => delimiter
scripts/utils.mjs:112: delimeter => delimiter
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Walkthrough

This PR fixes spelling errors in comments and strings across script files, and corrects variable naming. Changes include comment spelling fixes in agent.mjs, bootstrap.sh, machine.mjs; label description correction in label-issue.ts; and variable renaming from delimeter to delimiter in runner.node.mjs and utils.mjs.

Changes

Cohort / File(s) Change Summary
Comment Spelling Corrections
scripts/agent.mjs, scripts/bootstrap.sh, scripts/machine.mjs
Fixed spelling errors in comments: "propogates" → "propagates", "betwen" → "between", "polution" → "pollution"
String/Label Correction
scripts/label-issue.ts
Corrected description string for "wintercg" label: "compatiblity" → "compatibility"
Variable Naming Refactoring
scripts/runner.node.mjs, scripts/utils.mjs
Renamed local variable from "delimeter" to "delimiter" and updated usage in string interpolation

Suggested reviewers

  • nektro

Pre-merge checks

✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description includes both required sections ('What does this PR do?' and 'How did you verify your code works?') with specific details about the changes and verification approach.
Title check ✅ Passed The title directly and clearly summarizes the main change: fixing spelling errors across multiple files in the scripts directory.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b80cb62 and ed8ac45.

📒 Files selected for processing (6)
  • scripts/agent.mjs (1 hunks)
  • scripts/bootstrap.sh (1 hunks)
  • scripts/label-issue.ts (1 hunks)
  • scripts/machine.mjs (1 hunks)
  • scripts/runner.node.mjs (1 hunks)
  • scripts/utils.mjs (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
scripts/utils.mjs (1)
scripts/runner.node.mjs (6)
  • delimiter (2178-2178)
  • content (261-261)
  • content (500-500)
  • content (505-505)
  • content (2179-2179)
  • value (2261-2261)
scripts/runner.node.mjs (1)
scripts/utils.mjs (9)
  • delimiter (111-111)
  • content (112-112)
  • content (952-952)
  • content (2375-2375)
  • name (3009-3009)
  • value (36-36)
  • value (58-58)
  • value (148-148)
  • value (2220-2220)
🔇 Additional comments (5)
scripts/bootstrap.sh (1)

453-458: Comment spelling fix is fine

The updated pkg/OpenBSD comment (“between”) improves clarity and does not affect behavior.

scripts/runner.node.mjs (1)

2173-2181: Delimiter rename is correct and consistent

Renaming delimeterdelimiter and updating the template keeps the GitHub Actions multiline output format unchanged while improving readability and consistency with scripts/utils.mjs.

scripts/machine.mjs (1)

1193-1201: Spelling fix in tag comment looks good

The corrected “pollution” spelling clarifies the intent of the CI tag comment without affecting runtime behavior.

scripts/agent.mjs (1)

136-145: Windows shell comment typo fixed correctly

The comment about Command Prompt propagating exit codes is now spelled correctly; implementation remains the same.

scripts/label-issue.ts (1)

288-291: WinterCG label description correction is appropriate

Updating the description to “Web-interoperable Runtimes Community Group compatibility” fixes the typo without changing how labels are handled.

Comment on lines 108 to 114
if (isGithubAction && !/^GITHUB_/i.test(name)) {
const envFilePath = process.env["GITHUB_ENV"];
if (envFilePath) {
const delimeter = Math.random().toString(36).substring(2, 15);
const content = `${name}<<${delimeter}\n${value}\n${delimeter}\n`;
const delimiter = Math.random().toString(36).substring(2, 15);
const content = `${name}<<${delimiter}\n${value}\n${delimiter}\n`;
appendFileSync(outputPath, content);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Fix undefined outputPath when writing to GITHUB_ENV

The delimiter rename is good and matches scripts/runner.node.mjs, but this block still calls appendFileSync(outputPath, content), while the actual path is stored in envFilePath. This will cause a ReferenceError when setEnv runs under GitHub Actions with GITHUB_ENV set.

Recommend wiring the correct variable:

   if (isGithubAction && !/^GITHUB_/i.test(name)) {
-    const envFilePath = process.env["GITHUB_ENV"];
-    if (envFilePath) {
-      const delimiter = Math.random().toString(36).substring(2, 15);
-      const content = `${name}<<${delimiter}\n${value}\n${delimiter}\n`;
-      appendFileSync(outputPath, content);
-    }
+    const envFilePath = process.env["GITHUB_ENV"];
+    if (envFilePath) {
+      const delimiter = Math.random().toString(36).substring(2, 15);
+      const content = `${name}<<${delimiter}\n${value}\n${delimiter}\n`;
+      appendFileSync(envFilePath, content);
+    }
   }

This bug is pre-existing but fixing it here would make setEnv usable in GitHub Actions.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if (isGithubAction && !/^GITHUB_/i.test(name)) {
const envFilePath = process.env["GITHUB_ENV"];
if (envFilePath) {
const delimeter = Math.random().toString(36).substring(2, 15);
const content = `${name}<<${delimeter}\n${value}\n${delimeter}\n`;
const delimiter = Math.random().toString(36).substring(2, 15);
const content = `${name}<<${delimiter}\n${value}\n${delimiter}\n`;
appendFileSync(outputPath, content);
}
if (isGithubAction && !/^GITHUB_/i.test(name)) {
const envFilePath = process.env["GITHUB_ENV"];
if (envFilePath) {
const delimiter = Math.random().toString(36).substring(2, 15);
const content = `${name}<<${delimiter}\n${value}\n${delimiter}\n`;
appendFileSync(envFilePath, content);
}
}
🤖 Prompt for AI Agents
In scripts/utils.mjs around lines 108 to 114, the code writes to appendFileSync
using an undefined variable outputPath instead of the GitHub Actions env file
path; replace outputPath with envFilePath so the content is appended to
process.env["GITHUB_ENV"] (envFilePath) when present, ensuring the generated
delimiter/content is written to the correct file under GitHub Actions.

@syan212 syan212 changed the title Fix spelling in scripts/ Fix spelling in scripts/* Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant