-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix spelling in scripts/* #25396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix spelling in scripts/* #25396
Conversation
Details: Comments scripts/agent.mjs:139: propogates => propagates scripts/bootstrap.sh:453: betwen => between scripts/label-issue.ts:289: compatiblity => compatibility scripts/machine.mjs:1196: polution => pollution Variable names scripts/runner.node.mjs:2178: delimeter => delimiter scripts/runner.node.mjs:2179: delimeter => delimiter scripts/runner.node.mjs:2179: delimeter => delimiter scripts/utils.mjs:111: delimeter => delimiter scripts/utils.mjs:112: delimeter => delimiter scripts/utils.mjs:112: delimeter => delimiter
WalkthroughThis PR fixes spelling errors in comments and strings across script files, and corrects variable naming. Changes include comment spelling fixes in agent.mjs, bootstrap.sh, machine.mjs; label description correction in label-issue.ts; and variable renaming from delimeter to delimiter in runner.node.mjs and utils.mjs. Changes
Suggested reviewers
Pre-merge checks✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (6)
scripts/agent.mjs(1 hunks)scripts/bootstrap.sh(1 hunks)scripts/label-issue.ts(1 hunks)scripts/machine.mjs(1 hunks)scripts/runner.node.mjs(1 hunks)scripts/utils.mjs(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
scripts/utils.mjs (1)
scripts/runner.node.mjs (6)
delimiter(2178-2178)content(261-261)content(500-500)content(505-505)content(2179-2179)value(2261-2261)
scripts/runner.node.mjs (1)
scripts/utils.mjs (9)
delimiter(111-111)content(112-112)content(952-952)content(2375-2375)name(3009-3009)value(36-36)value(58-58)value(148-148)value(2220-2220)
🔇 Additional comments (5)
scripts/bootstrap.sh (1)
453-458: Comment spelling fix is fineThe updated pkg/OpenBSD comment (“between”) improves clarity and does not affect behavior.
scripts/runner.node.mjs (1)
2173-2181: Delimiter rename is correct and consistentRenaming
delimeter→delimiterand updating the template keeps the GitHub Actions multiline output format unchanged while improving readability and consistency withscripts/utils.mjs.scripts/machine.mjs (1)
1193-1201: Spelling fix in tag comment looks goodThe corrected “pollution” spelling clarifies the intent of the CI tag comment without affecting runtime behavior.
scripts/agent.mjs (1)
136-145: Windows shell comment typo fixed correctlyThe comment about Command Prompt propagating exit codes is now spelled correctly; implementation remains the same.
scripts/label-issue.ts (1)
288-291: WinterCG label description correction is appropriateUpdating the description to “Web-interoperable Runtimes Community Group compatibility” fixes the typo without changing how labels are handled.
| if (isGithubAction && !/^GITHUB_/i.test(name)) { | ||
| const envFilePath = process.env["GITHUB_ENV"]; | ||
| if (envFilePath) { | ||
| const delimeter = Math.random().toString(36).substring(2, 15); | ||
| const content = `${name}<<${delimeter}\n${value}\n${delimeter}\n`; | ||
| const delimiter = Math.random().toString(36).substring(2, 15); | ||
| const content = `${name}<<${delimiter}\n${value}\n${delimiter}\n`; | ||
| appendFileSync(outputPath, content); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix undefined outputPath when writing to GITHUB_ENV
The delimiter rename is good and matches scripts/runner.node.mjs, but this block still calls appendFileSync(outputPath, content), while the actual path is stored in envFilePath. This will cause a ReferenceError when setEnv runs under GitHub Actions with GITHUB_ENV set.
Recommend wiring the correct variable:
if (isGithubAction && !/^GITHUB_/i.test(name)) {
- const envFilePath = process.env["GITHUB_ENV"];
- if (envFilePath) {
- const delimiter = Math.random().toString(36).substring(2, 15);
- const content = `${name}<<${delimiter}\n${value}\n${delimiter}\n`;
- appendFileSync(outputPath, content);
- }
+ const envFilePath = process.env["GITHUB_ENV"];
+ if (envFilePath) {
+ const delimiter = Math.random().toString(36).substring(2, 15);
+ const content = `${name}<<${delimiter}\n${value}\n${delimiter}\n`;
+ appendFileSync(envFilePath, content);
+ }
}This bug is pre-existing but fixing it here would make setEnv usable in GitHub Actions.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (isGithubAction && !/^GITHUB_/i.test(name)) { | |
| const envFilePath = process.env["GITHUB_ENV"]; | |
| if (envFilePath) { | |
| const delimeter = Math.random().toString(36).substring(2, 15); | |
| const content = `${name}<<${delimeter}\n${value}\n${delimeter}\n`; | |
| const delimiter = Math.random().toString(36).substring(2, 15); | |
| const content = `${name}<<${delimiter}\n${value}\n${delimiter}\n`; | |
| appendFileSync(outputPath, content); | |
| } | |
| if (isGithubAction && !/^GITHUB_/i.test(name)) { | |
| const envFilePath = process.env["GITHUB_ENV"]; | |
| if (envFilePath) { | |
| const delimiter = Math.random().toString(36).substring(2, 15); | |
| const content = `${name}<<${delimiter}\n${value}\n${delimiter}\n`; | |
| appendFileSync(envFilePath, content); | |
| } | |
| } |
🤖 Prompt for AI Agents
In scripts/utils.mjs around lines 108 to 114, the code writes to appendFileSync
using an undefined variable outputPath instead of the GitHub Actions env file
path; replace outputPath with envFilePath so the content is appended to
process.env["GITHUB_ENV"] (envFilePath) when present, ensuring the generated
delimiter/content is written to the correct file under GitHub Actions.
Details
Comments
scripts/agent.mjs:139: propogates => propagates
scripts/bootstrap.sh:453: betwen => between
scripts/label-issue.ts:289: compatiblity => compatibility
scripts/machine.mjs:1196: polution => pollution
Variable names
scripts/runner.node.mjs:2178: delimeter => delimiter
scripts/runner.node.mjs:2179: delimeter => delimiter
scripts/runner.node.mjs:2179: delimeter => delimiter
scripts/utils.mjs:111: delimeter => delimiter
scripts/utils.mjs:112: delimeter => delimiter
scripts/utils.mjs:112: delimeter => delimiter
What does this PR do?
Corrects some spelling mistakes in scripts/
How did you verify your code works?
All changes did not affect actual functionality,