Skip to content

fix(console): add 'Assertion failed:' prefix to console.assert() with message #25376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murataslan1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(console): add 'Assertion failed:' prefix to console.assert() with message #25376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/bun.js/ConsoleObject.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,19 @@ fn messageWithTypeAndLevel_(
return;
}

// Print "Assertion failed: " prefix when console.assert has arguments
if (message_type == .Assert and len > 0) {
const prefix = if (Output.enable_ansi_colors_stderr)
Output.prettyFmt("<r><red>Assertion failed<r><d>:<r> ", true)
else
"Assertion failed: ";
const prefix_writer = if (level == .Warning or level == .Error)
console.error_writer
else
console.writer;
prefix_writer.writeAll(prefix) catch {};
}

const enable_colors = if (level == .Warning or level == .Error)
Output.enable_ansi_colors_stderr
else
Expand Down